Skip to content

v13: cleanup pass on release notes #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

v13: cleanup pass on release notes #835

merged 1 commit into from
Jul 22, 2025

Conversation

fenekku
Copy link
Collaborator

@fenekku fenekku commented Jul 21, 2025 •
edited
Loading

My pass on the release notes / how to upgrade.

fenekku
fenekku commented Jul 21, 2025
View reviewed changes
docs/releases/v13/version-v13.0.0.md
@@ -68,15 +68,17 @@ Collections introduce a powerful new way to organize and curate records within y
Collections provide dedicated pages showing all records matching specific criteria.
///

**Hierarchical organization**
*Hierarchical organization*

Copy link
Collaborator Author

@fenekku fenekku Jul 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ** made this header look like the Collections header even if it's below it. Italicizing and making sure to add new line makes it clearer that it is under the Collections section.

@fenekku fenekku changed the title v13: cleanup pass on notes v13: cleanup pass on release notes Jul 21, 2025
@fenekku fenekku requested review from utnapischtim and ntarocco July 21, 2025 20:35
@fenekku fenekku added this to v13.0.0 Jul 21, 2025
@fenekku fenekku moved this to 👀 In review in v13.0.0 Jul 21, 2025
@fenekku fenekku mentioned this pull request Jul 21, 2025
Closed
15 tasks
tmorrell
tmorrell approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one quick comment.

@fenekku fenekku force-pushed the release_notes_review branch from 301c152 to d32ea2d Compare July 21, 2025 20:58
@tmorrell tmorrell moved this from 👀 In review to Needed in v13.0.0 Jul 21, 2025
ntarocco
ntarocco reviewed Jul 22, 2025
View reviewed changes
@fenekku fenekku force-pushed the release_notes_review branch from d32ea2d to 70f4e80 Compare July 22, 2025 12:37
@fenekku fenekku requested a review from ntarocco July 22, 2025 12:40
carlinmack
carlinmack reviewed Jul 22, 2025
View reviewed changes
@fenekku fenekku force-pushed the release_notes_review branch from 70f4e80 to 5e99af9 Compare July 22, 2025 13:03
@fenekku fenekku requested a review from carlinmack July 22, 2025 13:12
@fenekku fenekku force-pushed the release_notes_review branch 2 times, most recently from b2a52ee to 0407a01 Compare July 22, 2025 13:59
carlinmack
carlinmack reviewed Jul 22, 2025
View reviewed changes
docs/releases/v13/version-v13.0.0.md Outdated
@@ -159,7 +162,7 @@ We have introduced new metadata fields that will allow you to capture more usefu
The v13 release features an upgraded PDF previewer, now powered by [PDF.js v4](https://github.com/mozilla/pdf.js). This update resolves previous issues with failed previews for certain PDF files, providing a more reliable and seamless viewing experience.

### Requests sharing
Copy link
Contributor

@carlinmack carlinmack Jul 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old:
When a record is shared, the review request is now also accessible. We have introduced a new search filter in My Dashboard, to easily find records shared with you.

Suggested change
### Requests sharing
We have introduced a new search filter in your dashboard so you can easily find records and requests shared with you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it's saying I want to remove the heading 😅 the important thing is we shouldn't mention "review request" as we aren't introducing that in this release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but maybe the heading should be

### Dashboard

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it's saying I want to remove the heading 😅 the important thing is we shouldn't mention "review request" as we aren't introducing that in this release

It's the location of the code suggestion: if it was done on L165 it would target the sentence we want 😁 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's weird though as you usually can't comment on lines that aren't changed in the PR 😅 I think it's something to do with the rebasing (but not a problem)

@fenekku fenekku force-pushed the release_notes_review branch from 0407a01 to b11f437 Compare July 22, 2025 14:16
carlinmack
carlinmack reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@carlinmack carlinmack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost perfect :) (I had to submit this review so the comment would post? I think there's a bug)

docs/releases/v13/version-v13.0.0.md Outdated
@@ -159,7 +162,7 @@ We have introduced new metadata fields that will allow you to capture more usefu
The v13 release features an upgraded PDF previewer, now powered by [PDF.js v4](https://github.com/mozilla/pdf.js). This update resolves previous issues with failed previews for certain PDF files, providing a more reliable and seamless viewing experience.

### Requests sharing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but maybe the heading should be

### Dashboard

@fenekku fenekku force-pushed the release_notes_review branch 3 times, most recently from 5d4aaee to 3176c95 Compare July 22, 2025 14:30
@fenekku fenekku force-pushed the release_notes_review branch from 3176c95 to c65a615 Compare July 22, 2025 14:35
@fenekku fenekku merged commit db0cb7d into inveniosoftware:master Jul 22, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Needed to To release 🤖 in v13.0.0 Jul 22, 2025
@fenekku fenekku deleted the release_notes_review branch July 22, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlinmack carlinmack carlinmack approved these changes

@tmorrell tmorrell tmorrell approved these changes

@utnapischtim utnapischtim Awaiting requested review from utnapischtim

@ntarocco ntarocco Awaiting requested review from ntarocco

Assignees
No one assigned
Labels
None yet
Projects
v13.0.0
Status: To release 🤖
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fenekku @utnapischtim @ntarocco @carlinmack @tmorrell