-
Notifications
You must be signed in to change notification settings - Fork 74
v13: cleanup pass on release notes #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -68,15 +68,17 @@ Collections introduce a powerful new way to organize and curate records within y | |||
Collections provide dedicated pages showing all records matching specific criteria. | |||
/// | |||
|
|||
**Hierarchical organization** | |||
*Hierarchical organization* | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The **
made this header look like the Collections header even if it's below it. Italicizing and making sure to add new line makes it clearer that it is under the Collections section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one quick comment.
301c152
to
d32ea2d
Compare
d32ea2d
to
70f4e80
Compare
70f4e80
to
5e99af9
Compare
b2a52ee
to
0407a01
Compare
docs/releases/v13/version-v13.0.0.md
Outdated
@@ -159,7 +162,7 @@ We have introduced new metadata fields that will allow you to capture more usefu | |||
The v13 release features an upgraded PDF previewer, now powered by [PDF.js v4](https://github.com/mozilla/pdf.js). This update resolves previous issues with failed previews for certain PDF files, providing a more reliable and seamless viewing experience. | |||
|
|||
### Requests sharing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old:
When a record is shared, the review request is now also accessible. We have introduced a new search filter in My Dashboard
, to easily find records shared with you.
### Requests sharing | |
We have introduced a new search filter in your dashboard so you can easily find records and requests shared with you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why it's saying I want to remove the heading 😅 the important thing is we shouldn't mention "review request" as we aren't introducing that in this release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but maybe the heading should be
### Dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why it's saying I want to remove the heading 😅 the important thing is we shouldn't mention "review request" as we aren't introducing that in this release
It's the location of the code suggestion: if it was done on L165 it would target the sentence we want 😁 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's weird though as you usually can't comment on lines that aren't changed in the PR 😅 I think it's something to do with the rebasing (but not a problem)
0407a01
to
b11f437
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost perfect :) (I had to submit this review so the comment would post? I think there's a bug)
docs/releases/v13/version-v13.0.0.md
Outdated
@@ -159,7 +162,7 @@ We have introduced new metadata fields that will allow you to capture more usefu | |||
The v13 release features an upgraded PDF previewer, now powered by [PDF.js v4](https://github.com/mozilla/pdf.js). This update resolves previous issues with failed previews for certain PDF files, providing a more reliable and seamless viewing experience. | |||
|
|||
### Requests sharing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but maybe the heading should be
### Dashboard
5d4aaee
to
3176c95
Compare
3176c95
to
c65a615
Compare
My pass on the release notes / how to upgrade.