Skip to content

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Feb 21, 2025

Follow up to #6293
Adds a debug window that shows past authentications (only for superusers)
grafik
And here after a mandatory re-auth to change or view security-relevant information
grafik

@matmair matmair added enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface labels Feb 21, 2025
@matmair matmair added this to the 1.0.0 milestone Feb 21, 2025
@matmair matmair self-assigned this Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit f6077a5
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/68b80295c3f8310008252775
😎 Deploy Preview https://deploy-preview-9120--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🟢 up 9 from production)
Accessibility: 81 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.37%. Comparing base (085381f) to head (f6077a5).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9120      +/-   ##
==========================================
- Coverage   87.37%   87.37%   -0.01%     
==========================================
  Files        1266     1266              
  Lines       56486    56482       -4     
  Branches     2064     2061       -3     
==========================================
- Hits        49357    49351       -6     
- Misses       6621     6624       +3     
+ Partials      508      507       -1     
Components Coverage Δ
Backend Apps 91.62% <ø> (ø)
Backend General 93.64% <ø> (ø)
Frontend 70.05% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matmair matmair marked this pull request as ready for review February 24, 2025 21:07
@matmair matmair marked this pull request as draft April 24, 2025 23:10
@matmair matmair marked this pull request as ready for review June 10, 2025 22:55
@matmair
Copy link
Contributor Author

matmair commented Jun 11, 2025

@SchrodingersGat ready for review and merge

@SchrodingersGat
Copy link
Member

I still think it would be generally useful to be able to see this in the "admin center" view (still only for superusers) to view all logged in session information. Much like the view we had in the old UI. All the API / data is already there, just needs to be formatted into a superuser-only table?

@matmair
Copy link
Contributor Author

matmair commented Jun 23, 2025

Not sure; login sessions is something different than what it achieved here.
This PR adds debug info for the current session - including multifactor re-authentications. This is usefull to debug various mfa issues

@SchrodingersGat
Copy link
Member

@matmair this is the last outstanding 1.0.0 issue (currently) - do you want to fix the UI errors and I'll review again? Or, push off?

@matmair
Copy link
Contributor Author

matmair commented Sep 3, 2025

looking into it now

@matmair
Copy link
Contributor Author

matmair commented Sep 3, 2025

@SchrodingersGat can you be more specific what errors you are referring to? It seems to work as intended
grafik

@SchrodingersGat
Copy link
Member

@matmair it was just failing the frontend tests, seems to be OK now.

I have a slightly adjusted branch which moves this auth session table into the "user settings / security" panel - would you be OK with this? I think this is much cleaner while retaining functionality

image

@matmair
Copy link
Contributor Author

matmair commented Sep 4, 2025

I guess so. The whole window is only shown for superusers and mostly helpful for quick passkey debugging but 2 extra clicks are probably not too bad in every debug.

@SchrodingersGat
Copy link
Member

Replaced by #10271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants