deep inheritance (3+ levels) and injectFromBase decorator

[viceice]

I've three or more classes with inheritance and property injection.
I recently switched to v7, so i need to use injectFromBase decorator.

Do i need that on all abtract classes in the hierachy or only on the last / final class?

@injectable()
abstract class A {
  @inject('x') x: string;
}

@injectable()
@injectFromBase() // do i need this?
abstract class B extends A {
  @inject('y') y: string;
}


@injectable()
@injectFromBase()
class C extends B {
  @inject('z') z: string;
}

[notaphplover]

Hey @viceice,

Do i need that on all abtract classes in the hierachy or only on the last / final class?

Exactly, you need to specify it in every level of the hierarchy starting with the first child class.

Out of curiosity, is it painful to go this way? Tbh I could easily provide a decorator that injects from every ancestor class, but I though it makes sense to do it this way. I'm always looking for user feedback, so feel free to describe your experience. It doesn't mean I will automatically change the API as you wish, but I'll keep your opinnion in mind 🙂

[viceice]

it was a little bit painful because of a lot of work for the v7 migration, see pr below.

• fix(deps): update dependency inversify to v7 (main) containerbase/base#4237

it would be nice it would only be required on final class.
it would also be nice to have it as parameter of @injectable() decorator, so i don't need two decorator.

[viceice]

btw i also migrated to property injection before to make it simpler, so i don't need to pass all injections to the hierachies

• containerbase/base@b5a073f

[notaphplover]

Yeah, those are a lot of changes. I think I can provide some options to the injectFromBase decorator.

I would prefer not to update injectable though. It shouldn't have that responsibility.

Once we allow injectFromBase with a recursive options, you can easily make your own decorator to avoid declaring two decorators:

export function myCustomInjectableDecorator(scope?: BindingScope): ClassDecorator {
  return (target: Function): void {
    injectable(scope)(target);
    injectFromBase({ recursive: true })(target);
  }
}

[notaphplover]

inversify@7.8.1 comes with an injectFromHierarchy decorator. I hope you like it 🙂