Skip to content

feat(messaging, android): Add check for expo-notifications notification icon configurations #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lewiscasewell
Copy link

@lewiscasewell lewiscasewell commented Jun 9, 2025

Description

When using expo-notifications in combination with @react-native-firebase/messaging for things like scheduling notifications now and other expo-notifications features we ran into an issue where the config wasn't being set in the recommended plugins approach in their docs. This meant some android devices didn't have a notification icon - e.g. like this issue here expo/expo#24844

The goal of this is to add a check for expo-notifications plugin and uses the configuration for notification icon and color. If there is also a notification.icon and notification.color set then we will override with these values from the plugin.

Related issues

As mentioned above we saw similar behaviour to this expo/expo#24844 with mentions of this library. But we still had the problem.

Release Summary

Adds a check for expo-notifications plugin and uses the configuration for notification icon and color if notification.icon and noticiation.color doesn't already exist respectively

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Screenshot 2025-06-09 at 22 31 03

Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jun 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 8:15pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lewiscasewell lewiscasewell changed the title Add check for expo-notifications notification icon configurations feat: Add check for expo-notifications notification icon configurations Jun 9, 2025
@lewiscasewell lewiscasewell changed the title feat: Add check for expo-notifications notification icon configurations feat(messaging, android): Add check for expo-notifications notification icon configurations Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants