feat(messaging, android): Add check for expo-notifications notification icon configurations #8563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
expo-notifications
in combination with@react-native-firebase/messaging
for things like scheduling notifications now and otherexpo-notifications
features we ran into an issue where the config wasn't being set in the recommended plugins approach in their docs. This meant some android devices didn't have a notification icon - e.g. like this issue here expo/expo#24844The goal of this is to add a check for
expo-notifications
plugin and uses the configuration for notification icon and color. If there is also anotification.icon
andnotification.color
set then we will override with these values from the plugin.Related issues
As mentioned above we saw similar behaviour to this expo/expo#24844 with mentions of this library. But we still had the problem.
Release Summary
Adds a check for
expo-notifications
plugin and uses the configuration for notification icon and color ifnotification.icon
andnoticiation.color
doesn't already exist respectivelyChecklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter