fix(nativeview, ios): use correct prop type for NativeView #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~790 Documentation is deployed and generated using docs.page. |
|
|
|
🎉 This PR is included in version 15.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The NativeView was previously using the banner prop type (RNGoogleMobileAdsBannerViewProps) in
initWithFrame.While this is currently identical to the nativead prop and causes no functional issues, it could lead to problems in the future if the two props diverge.
This change updates the prop type to ensure consistency and prevent potential issues down the line.
Related issues
Release Summary
Updated
NativeViewto use the correct native view prop type.Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter