-
Notifications
You must be signed in to change notification settings - Fork 74
feat(react): support firebase v12 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~193 Documentation is deployed and generated using docs.page. |
We should probably make sure peer dependencies are updated and backwards compatible (https://github.com/invertase/tanstack-query-firebase/blob/%40invertase/support-firebase-v12/packages/react/package.json#L47), so support 11.3 or 12 |
Sure, also noticed angularfire is still not yet supporting firebase@12, so had to remove firebase dependency from the root to prevent mismatches in packages and moved it to the be devdependency in packages. For dataconnect workspace package, expanded the range of supported versions to include firebase@v12 since its shared by both react and angular packages |
Just been thinking...for the angular package, should we allow angularfire to manage the firebase version? So that we always take the firebase peer from angularfire? This is because currently we do support firebase@11.3.0 but angularfire currently seems to have a different version of firebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Firebase v12 by updating peer dependency version ranges across multiple packages in the workspace. The change enables the project to work with the latest Firebase SDK while maintaining backward compatibility.
- Updates Firebase peer dependency ranges to include v12 support
- Adds Firebase v12 as a dev dependency for testing
- Removes workspace-level Firebase dependency in favor of package-specific dependencies
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/package.json | Adds Firebase v12 as dev dependency and updates peer dependency range |
package.json | Removes workspace-level Firebase dependency |
dataconnect-sdk/js/default-connector/package.json | Updates peer dependency range to include Firebase v12 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/react/package.json:43
- Firebase v12.0.0 may not exist yet. My knowledge cutoff is January 2025, and Firebase v11 was the latest major version at that time. Please verify that Firebase v12 has been released before adding this dependency.
"firebase": "^12.0.0",
92ad5ce
to
9a9a2de
Compare
🦋 Changeset detectedLatest commit: 1a916d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Let's leave this for another PR, to keep this one focused. |
Sure, sounds good! |
60c9ab0
to
1a916d7
Compare
Fixes #192