Skip to content

feat: bump firebase versions in react package #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cabljac
Copy link
Collaborator

@cabljac cabljac commented Jul 30, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 30, 2025 14:31
Copy link

changeset-bot bot commented Jul 30, 2025

⚠️ No Changeset found

Latest commit: 38512b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

docs-page bot commented Jul 30, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~198

Documentation is deployed and generated using docs.page.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Firebase version support to include Firebase 12.x alongside the existing Firebase 11.x support across the React package and related dependencies.

  • Expands Firebase peer dependency to support both v11.3.0+ and v12.0.0+
  • Updates root package Firebase dev dependency to v11.10.0
  • Adds CI workflow to test Firebase 12 compatibility

Reviewed Changes

Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/package.json Updates peer dependency to support Firebase 12
package.json Bumps dev dependency and adds Firebase 12 test script
examples/react-example/package.json Updates Firebase dependency range to support v12
dataconnect-sdk/js/default-connector/index.cjs.js Code formatting changes (generated file)
dataconnect-sdk/js/default-connector/esm/package.json JSON formatting change
dataconnect-sdk/js/default-connector/esm/index.esm.js Code formatting changes (generated file)
.github/workflows/tests.yaml Adds new CI job to test Firebase 12 compatibility
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)

package.json:8

  • Firebase version 12.0.0 does not exist. Firebase is currently at version 11.x. The peer dependency and test script reference a non-existent version.
    "test:firebase12": "pnpm add -Dw firebase@^12.0.0 && firebase emulators:exec --project test-project \"pnpm turbo test:ci --filter=@tanstack-query-firebase/react\" && pnpm add -Dw firebase@^11.10.0 --ignore-workspace-root-check",

packages/react/package.json:48

  • Firebase version 12.0.0 does not exist. This peer dependency range includes a non-existent version that could cause installation issues.
    "firebase": "^11.3.0 || ^12.0.0"

examples/react-example/package.json:15

  • Firebase version 12.0.0 does not exist. This dependency range includes a non-existent version.
    "firebase": "^11.3.0 || ^12.0.0",

@cabljac cabljac force-pushed the @invertase/bump-firebase branch from 0a02c35 to 986a53f Compare July 30, 2025 15:24
@cabljac cabljac force-pushed the @invertase/bump-firebase branch 2 times, most recently from 5c958da to 0b26768 Compare July 30, 2025 16:08
@cabljac cabljac force-pushed the @invertase/bump-firebase branch from 0b26768 to 15a4c9e Compare July 30, 2025 16:10
@cabljac cabljac force-pushed the @invertase/bump-firebase branch from fed31c9 to 7cce88a Compare July 30, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant