Skip to content

Feat(ui): Import lora metadata from json #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2025

Conversation

hipsterusername
Copy link
Member

Summary

During model import, this checks to see if an image or .json file matching the file exist (in forge/a1111 format). If so, it imports relevant metadata and sets the cover image.

Related Issues / Discussions

Reddit request

QA Instructions

  • Test model upload w/ image & metadata file in same folder.

Merge Plan

Merge if good to go.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added api python PRs that change python files services PRs that change app services python-tests PRs that change python tests labels Jul 21, 2025
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a take-a-step-back-and-rethink from Cursor. And tests w/ real-world test cases.

@github-actions github-actions bot added the backend PRs that change backend files label Jul 21, 2025
@hipsterusername
Copy link
Member Author

I've fixed the functionality, so it should be good there.

As far as adding "real-world tests" -- To what extent would you consider this real-world tested? Might need some pointers on where we stub out w hardcoded/rand data vs upload test images/files etc. into the test.

@hipsterusername hipsterusername force-pushed the import-lora-metadata-from-json branch from 59541bf to 8955d7c Compare July 21, 2025 19:07
@psychedelicious psychedelicious enabled auto-merge (rebase) July 21, 2025 21:28
@psychedelicious psychedelicious force-pushed the import-lora-metadata-from-json branch from 8955d7c to 5cb7c01 Compare July 21, 2025 21:28
@psychedelicious psychedelicious merged commit c3f6389 into main Jul 21, 2025
12 checks passed
@psychedelicious psychedelicious deleted the import-lora-metadata-from-json branch July 21, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api backend PRs that change backend files python PRs that change python files python-tests PRs that change python tests services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants