Skip to content

Conversation

chaoen
Copy link
Contributor

@chaoen chaoen commented Mar 24, 2016

No description provided.

chaoen added 3 commits March 24, 2016 08:09
sinon.spy() => sinon.spy(Object, method)
add file src/components/auth/registerUser.functional.spec.js
add file .travis.yml for travis-ci
add src/components/auth/loginUser.functional.spec.js
it's for login user functional test.
return new signInCtrl($auth, $state, $toast);
};
}));
it('signin form test', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should be defined as Unit Test.
And every test should be separated.

chaoen added 2 commits March 28, 2016 10:11
change describe to when doing something.
change it to when should doing something.
Remove unit test thing in loginUser and registerUser.
Change describe and it usage.
@Wilson-Su Wilson-Su added this to the sprint1 milestone Apr 12, 2016
@Wilson-Su
Copy link
Contributor

This PR has conflicts. Please resolve it.

JuliusChen pushed a commit that referenced this pull request Mar 21, 2017
Confirm translation and Remove needless judgment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants