Skip to content

Commit e66060b

Browse files
committed
feat(modal): add IonModalToken for injecting modal element in Angular components
1 parent c38aa07 commit e66060b

File tree

2 files changed

+28
-14
lines changed

2 files changed

+28
-14
lines changed

packages/angular/common/src/index.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,34 @@
1-
export { MenuController } from './providers/menu-controller';
21
export { DomController } from './providers/dom-controller';
2+
export { MenuController } from './providers/menu-controller';
33
export { NavController } from './providers/nav-controller';
44

55
export { Config, ConfigToken } from './providers/config';
66
export { Platform } from './providers/platform';
77

8-
export { bindLifecycleEvents, AngularDelegate } from './providers/angular-delegate';
8+
export { AngularDelegate, bindLifecycleEvents, IonModalToken } from './providers/angular-delegate';
99

1010
export type { IonicWindow } from './types/interfaces';
11-
export type { ViewWillEnter, ViewWillLeave, ViewDidEnter, ViewDidLeave } from './types/ionic-lifecycle-hooks';
11+
export type { ViewDidEnter, ViewDidLeave, ViewWillEnter, ViewWillLeave } from './types/ionic-lifecycle-hooks';
1212

1313
export { NavParams } from './directives/navigation/nav-params';
1414

15-
export { IonPopover } from './overlays/popover';
1615
export { IonModal } from './overlays/modal';
16+
export { IonPopover } from './overlays/popover';
1717

1818
export { IonRouterOutlet, provideComponentInputBinding } from './directives/navigation/router-outlet';
1919

20+
export * from './directives/control-value-accessors';
2021
export { IonBackButton } from './directives/navigation/back-button';
22+
export { IonNav } from './directives/navigation/nav';
2123
export {
2224
RouterLinkDelegateDirective,
23-
RouterLinkWithHrefDelegateDirective,
25+
RouterLinkWithHrefDelegateDirective
2426
} from './directives/navigation/router-link-delegate';
25-
export { IonNav } from './directives/navigation/nav';
2627
export { IonTabs } from './directives/navigation/tabs';
27-
export * from './directives/control-value-accessors';
2828

2929
export { ProxyCmp } from './utils/proxy';
3030

31-
export { IonicRouteStrategy } from './utils/routing';
3231
export { OverlayBaseController } from './utils/overlay';
32+
export { IonicRouteStrategy } from './utils/routing';
3333

3434
export { raf } from './utils/util';

packages/angular/common/src/providers/angular-delegate.ts

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import {
22
ApplicationRef,
3-
NgZone,
4-
Injectable,
5-
Injector,
3+
ComponentRef,
4+
createComponent,
65
EnvironmentInjector,
76
inject,
8-
createComponent,
7+
Injectable,
98
InjectionToken,
10-
ComponentRef,
9+
Injector,
10+
NgZone,
1111
} from '@angular/core';
1212
import {
1313
FrameworkDelegate,
@@ -22,6 +22,9 @@ import { NavParams } from '../directives/navigation/nav-params';
2222

2323
import { ConfigToken } from './config';
2424

25+
// Token for injecting the modal element
26+
export const IonModalToken = new InjectionToken<HTMLIonModalElement>('IonModalToken');
27+
2528
// TODO(FW-2827): types
2629

2730
@Injectable()
@@ -142,8 +145,19 @@ export const attachView = (
142145
* The modern approach is to access the data directly
143146
* from the component's class instance.
144147
*/
148+
const providers = getProviders(params);
149+
150+
// If this is an ion-modal, provide the modal element as an injectable
151+
// so components inside the modal can inject it directly
152+
if (container.tagName.toLowerCase() === 'ion-modal') {
153+
providers.push({
154+
provide: IonModalToken,
155+
useValue: container
156+
});
157+
}
158+
145159
const childInjector = Injector.create({
146-
providers: getProviders(params),
160+
providers,
147161
parent: injector,
148162
});
149163

0 commit comments

Comments
 (0)