Skip to content

feat(datetime): add styles for adjacent days for ionic theme #30492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

feat(datetime): add styles for adjacent days for ionic theme #30492

wants to merge 7 commits into from

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Jun 17, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

Now the adjacent days have proper styles for all their states.
And the next-prev month buttons have the right height.

Changes:

  • add styles for the adjacent days;
  • add styles for active adjacent day;
  • add styles for pressed adjacent day;
  • add styles for focused adjacent day;

Does this introduce a breaking change?

  • Yes
  • No

Other information

ionic preview

@vercel Vercel
Copy link

vercel bot commented Jun 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 5:11pm

@github-actions github-actions bot added the package: core @ionic/core package label Jun 17, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd marked this pull request as ready for review June 17, 2025 14:43
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner June 17, 2025 14:43
ShaneK
ShaneK approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me, but odd there are no screen changes I guess. Should we add screen tests for this in the future? Or are the colors just the same?

ShaneK
ShaneK approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneK ShaneK ShaneK approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoaoFerreira-FrontEnd @ShaneK @Ionitron