feat(datetime): add divider to datetime-action-buttons #30509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BenOsodrac
reviewed
Jun 24, 2025
| @include globals.padding(globals.$ion-space-200, globals.$ion-space-0, globals.$ion-space-200, globals.$ion-space-0); | ||
| margin-top: globals.$ion-space-200; | ||
|
|
||
| border-top: globals.$ion-border-style-solid globals.$ion-border-size-025 globals.$ion-primitives-neutral-300; |
There was a problem hiding this comment.
I believe you're supposed to use the margin and border mixins here
ShaneK
reviewed
Jun 25, 2025
| @include globals.padding(globals.$ion-space-200, globals.$ion-space-0, globals.$ion-space-200, globals.$ion-space-0); | ||
| margin-top: globals.$ion-space-200; | ||
|
|
||
| border-top: globals.$ion-border-style-solid globals.$ion-border-size-025 globals.$ion-primitives-neutral-300; |
There was a problem hiding this comment.
In addition to Ben's comment, where are these design details being pulled from? From the Figma, there is no border on the datepicker, unless it's been updated in a place I'm not aware of?
There was a problem hiding this comment.
I've updated the code to use the mixins. The design I sent it to you via JIRA comment.
There was a problem hiding this comment.
Awesome! Looks like you also need to update your screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Now, the action buttons have a divider for improved readability.
Does this introduce a breaking change?
Other information
ionic preview