Skip to content

fix(range): update tokens usage, and add pressed state #30601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 7, 2025

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Aug 5, 2025

Issue number: internal


What is the new behavior?

  • improve tokens usage;
  • increase white space to 44px square;

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 4:01pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 5, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd changed the title fix(range) - update tokens usage, and add pressed state fix(range): update tokens usage, and add pressed state Aug 5, 2025
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, great work!

@ShaneK ShaneK requested a review from brandyscarney August 6, 2025 21:32
JoaoFerreira-FrontEnd and others added 4 commits August 7, 2025 16:27
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I believe you just need to run npm run lint to merge. 🙂

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit feddbf9 into next Aug 7, 2025
49 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-12075 branch August 7, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants