feat(rules): add ion-radio-attributes-renamed rule (#24)

Author: imhoffd

README.md

@@ -370,9 +370,19 @@ We are looking for contributors to help build these rules out! See [`CONTRIBUTIN
     <td></td>
   </tr>
   <tr>
-    <th rowspan="2">
+    <th rowspan="3">
       <a href="https://github.com/ionic-team/ionic/blob/master/angular/BREAKING.md#radio">Radio</a>
     </th>
+    <td>:wrench:</td>
+    <td>:white_check_mark:</td>
+    <td>
+      <code>ion-radio-attributes-renamed</code>
+    </td>
+    <td>
+      <a href="https://github.com/dwieeb">@dwieeb</a>
+    </td>
+  </tr>
+  <tr>
     <td>:wrench:</td>
     <td>:white_check_mark:</td>
     <td>

src/ionRadioAttributesRenamedRule.ts

@@ -0,0 +1,31 @@
+import { NgWalker } from 'codelyzer/angular/ngWalker';
+import * as Lint from 'tslint';
+import * as ts from 'typescript';
+
+import { createAttributesRenamedTemplateVisitorClass } from './helpers/attributesRenamed';
+
+export const ruleName = 'ion-radio-attributes-renamed';
+
+const replacementMap = new Map([['item-left', 'slot="start"'], ['item-right', 'slot="end"']]);
+
+const IonFabAttributesRenamedTemplateVisitor = createAttributesRenamedTemplateVisitorClass('ion-radio', replacementMap);
+
+export class Rule extends Lint.Rules.AbstractRule {
+  public static metadata: Lint.IRuleMetadata = {
+    ruleName: ruleName,
+    type: 'functionality',
+    description: 'Attributes of ion-radio have been renamed.',
+    options: null,
+    optionsDescription: 'Not configurable.',
+    typescriptOnly: false,
+    hasFix: true
+  };
+
+  public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
+    return this.applyWithWalker(
+      new NgWalker(sourceFile, this.getOptions(), {
+        templateVisitorCtrl: IonFabAttributesRenamedTemplateVisitor
+      })
+    );
+  }
+}

test/ionRadioAttributesRenamed.spec.ts

@@ -0,0 +1,128 @@
+import { expect } from 'chai';
+import { Replacement, Utils } from 'tslint';
+import { ruleName } from '../src/ionRadioAttributesRenamedRule';
+import { assertAnnotated, assertFailure, assertFailures, assertMultipleAnnotated, assertSuccess } from './testHelper';
+
+describe(ruleName, () => {
+  describe('success', () => {
+    it('should work with proper style', () => {
+      let source = `
+      @Component({
+        template: \`<ion-radio slot="start"><ion-radio>\`
+      })
+      class Bar{}
+        `;
+      assertSuccess(ruleName, source);
+    });
+  });
+
+  describe('failure', () => {
+    it('should fail when item-left is used', () => {
+      let source = `
+      @Component({
+        template: \`
+          <ion-radio item-left></ion-radio>\`
+                     ~~~~~~~~~
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'The item-left attribute of ion-radio has been renamed. Use slot="start" instead.',
+        source
+      });
+    });
+
+    it('should fail when item-right is used', () => {
+      let source = `
+      @Component({
+        template: \`
+          <ion-radio item-right></ion-radio>\`
+                     ~~~~~~~~~~
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'The item-right attribute of ion-radio has been renamed. Use slot="end" instead.',
+        source
+      });
+    });
+  });
+
+  describe('replacements', () => {
+    it('should replace item-left with slot="start"', () => {
+      let source = `
+        @Component({
+          template: \`<ion-radio item-left></ion-radio>
+          \`
+        })
+        class Bar {}
+      `;
+
+      const fail = {
+        message: 'The item-left attribute of ion-radio has been renamed. Use slot="start" instead.',
+        startPosition: {
+          line: 2,
+          character: 32
+        },
+        endPosition: {
+          line: 2,
+          character: 41
+        }
+      };
+
+      const failures = assertFailure(ruleName, source, fail);
+      const fixes = failures.map(f => f.getFix());
+      const res = Replacement.applyAll(source, Utils.flatMap(fixes, Utils.arrayify));
+
+      let expected = `
+        @Component({
+          template: \`<ion-radio slot="start"></ion-radio>
+          \`
+        })
+        class Bar {}
+      `;
+
+      expect(res).to.eq(expected);
+    });
+
+    it('should replace item-right with slot="end"', () => {
+      let source = `
+        @Component({
+          template: \`<ion-radio item-right></ion-radio>
+          \`
+        })
+        class Bar {}
+      `;
+
+      const fail = {
+        message: 'The item-right attribute of ion-radio has been renamed. Use slot="end" instead.',
+        startPosition: {
+          line: 2,
+          character: 32
+        },
+        endPosition: {
+          line: 2,
+          character: 42
+        }
+      };
+
+      const failures = assertFailure(ruleName, source, fail);
+      const fixes = failures.map(f => f.getFix());
+      const res = Replacement.applyAll(source, Utils.flatMap(fixes, Utils.arrayify));
+
+      let expected = `
+        @Component({
+          template: \`<ion-radio slot="end"></ion-radio>
+          \`
+        })
+        class Bar {}
+      `;
+
+      expect(res).to.eq(expected);
+    });
+  });
+});