Skip to content

feat: add new hex address equivalence for mainnet profiles #8717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 4, 2025
Merged

feat: add new hex address equivalence for mainnet profiles #8717

merged 7 commits into from
Jun 4, 2025
+195 −17

Conversation

evavirseda
Copy link
Collaborator

Summary

fixes #8716

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda self-assigned this May 27, 2025
@evavirseda evavirseda requested a review from brancoder May 27, 2025 11:10
brancoder
brancoder reviewed May 27, 2025
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the task states to

Below the receive funds, add a new copiable box with the new address equivalence

In the task the address has been added to the same box as receive funds, should we push it under to a dedicated box?
image

brancoder
brancoder requested changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8717 (review)

@evavirseda evavirseda requested a review from brancoder May 28, 2025 09:29
brancoder
brancoder approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

begonaalvarezd
begonaalvarezd requested changes May 30, 2025
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are still missing the hex in the address history
image
We should display the address on each bip path and allow to copy it, and also allow to copy all by either adding it to the comma separated addresses or adding a new button for the new format specifically

@evavirseda evavirseda requested a review from begonaalvarezd May 30, 2025 14:29
brancoder
brancoder requested changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add the copy all button for new hex address formats as requested in this comment
#8717 (review)

@evavirseda evavirseda requested a review from brancoder June 2, 2025 07:03
brancoder
brancoder approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd merged commit 89c9e0d into develop Jun 4, 2025
4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-new-hex-address-equivalence-for-mainnet-profiles branch June 4, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@brancoder brancoder brancoder approved these changes

@msarcev msarcev Awaiting requested review from msarcev

Assignees

@evavirseda evavirseda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add new hex address equivalence for Mainnet profiles
3 participants
@evavirseda @begonaalvarezd @brancoder