Skip to content

upstream(iota-core): Make most interactions with the db panic on failure instead of returning Result #7187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: consensus/upstream-changes/sprint-21
Choose a base branch
from

Conversation

piotrm50
Copy link
Contributor

@piotrm50 piotrm50 commented Jun 2, 2025

Description of change

Port upstream change: Make most interactions with the db panic on failure instead of returning Result (#20291) MystenLabs/sui@9f617ef (PR: MystenLabs/sui#20291)

Links to any relevant issues

Fixes #7186

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

CI, local network

Make sure to provide instructions for the maintainer as well as any relevant configurations.

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)

Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure)

  • Synchronization of the indexer from genesis for a network including migration objects.
  • Restart of indexer synchronization locally without resetting the database.
  • Restart of indexer synchronization on a production-like database.
  • Deployment of services using Docker.
  • Verification of API backward compatibility.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@piotrm50 piotrm50 self-assigned this Jun 2, 2025
@piotrm50 piotrm50 added the consensus Issues related to the Core Consensus team label Jun 2, 2025
Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Jun 2, 2025 7:48am
apps-ui-kit ⬜️ Ignored (Inspect) Jun 2, 2025 7:48am
rebased-explorer ⬜️ Ignored (Inspect) Jun 2, 2025 7:48am
wallet-dashboard ⬜️ Ignored (Inspect) Jun 2, 2025 7:48am

@piotrm50 piotrm50 changed the base branch from develop to consensus/upstream-changes/sprint-21 June 2, 2025 07:49
@piotrm50 piotrm50 changed the title Make most interactions with the db panic on failure instead of returning Result upstream(iota-core): Make most interactions with the db panic on failure instead of returning Result Jun 2, 2025
@piotrm50
Copy link
Contributor Author

piotrm50 commented Jun 2, 2025

This is initially ported, but there is a dependency on #6907 and it's better to merge it after that - that's why it's marked as draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to the Core Consensus team core-protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream(consensus): Make most interactions with the db panic on failure instead of returning Result (#20291)
2 participants