Skip to content

feat(explorer): add balance breakdown to address page #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 4, 2025
Merged

feat(explorer): add balance breakdown to address page #7198

merged 21 commits into from
Jun 4, 2025

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jun 2, 2025

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Fixes #7191

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@VmMad VmMad requested a review from a team as a code owner June 2, 2025 16:26
@VmMad VmMad added tooling Issues related to the Tooling team explorer Issues related to the Explorer wallet-dashboard Issues related to the Wallet Dashboard dApp labels Jun 2, 2025
@vercel Vercel
Copy link

vercel bot commented Jun 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 0:23am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 0:23am
apps-backend ⬜️ Skipped (Inspect) Jun 4, 2025 0:23am
wallet-dashboard ⬜️ Skipped (Inspect) 💬 Add feedback Jun 4, 2025 0:23am

@vercel vercel bot temporarily deployed to Preview – apps-backend June 2, 2025 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer June 2, 2025 16:38 Inactive
evavirseda
evavirseda requested changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci is failing 🙏

@VmMad VmMad requested a review from evavirseda June 3, 2025 07:50
evavirseda
evavirseda requested changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a suggestion, let me know what you think 😊 🙏

@github-actions github-actions bot added the apps-ui-kit Issues related to the Apps UI Kit label Jun 3, 2025
@VmMad VmMad requested a review from evavirseda June 3, 2025 11:09
@VmMad
Copy link
Member Author

VmMad commented Jun 4, 2025

improve @iota/core imports

Not possible since it would break JEST because of the components in iota/core, the imports need to be specific.

brancoder
brancoder requested changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message suggestions

@vercel vercel bot temporarily deployed to Preview – apps-backend June 4, 2025 09:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard June 4, 2025 09:12 Inactive
brancoder
brancoder requested changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small improvement to totalTimleockedStake calculation

@VmMad VmMad requested a review from brancoder June 4, 2025 09:43
brancoder
brancoder approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview – wallet-dashboard June 4, 2025 12:20 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend June 4, 2025 12:20 Inactive
begonaalvarezd
begonaalvarezd approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@begonaalvarezd begonaalvarezd merged commit 6e45a2a into develop Jun 4, 2025
31 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-explorer/add-balance-breakdown branch June 4, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@brancoder brancoder brancoder approved these changes

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
apps-ui-kit Issues related to the Apps UI Kit explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add balance breakdown to address page
4 participants
@VmMad @begonaalvarezd @brancoder @evavirseda