Skip to content

feat: add support for did ethr #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vasa-develop
Copy link

This may require a bit of cleanup.

Added:

  • support for did ethr
  • an error type

License: MIT
Signed-off-by: Vaibhav Saini vasa@towardsblockchain.com

License: MIT
Signed-off-by: Vaibhav Saini <vasa@towardsblockchain.com>
License: MIT
Signed-off-by: Vaibhav Saini <vasa@towardsblockchain.com>
@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #3 into master will increase coverage by 3.16%.
The diff coverage is 28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3      +/-   ##
=======================================
+ Coverage    6.83%   10%   +3.16%     
=======================================
  Files           4     4              
  Lines         117   140      +23     
  Branches       18    22       +4     
=======================================
+ Hits            8    14       +6     
- Misses         91   105      +14     
- Partials       18    21       +3
Impacted Files Coverage Δ
src/errors.js 0% <0%> (ø) ⬆️
src/did-resolver.js 22.85% <29.16%> (+7.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b8eaf...43a946d. Read the comment docs.

@vasa-develop
Copy link
Author

Going forward, we should add some more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants