Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fixes: #861
Description
The service worker was always storing responses in the mutable cache, regardless of protocol type (IPFS vs IPNS).
fetchAndUpdateCache()
to acceptisMutable
as a parametergetResponseFromCacheOrFetch()
to pass the correctisMutable
value based on protocol:isMutable = true
for IPNS (mutable content)isMutable = false
for IPFS (immutable content)Notes & open questions
Change checklist
Reviewer: @SgtPooki