Skip to content

fix: broken cache #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: broken cache #885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/sw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ function getCacheKey (event: FetchEvent): string {
return `${event.request.url}-${event.request.headers.get('Accept') ?? ''}`
}

async function fetchAndUpdateCache (event: FetchEvent, url: URL, cacheKey: string): Promise<Response> {
async function fetchAndUpdateCache (event: FetchEvent, url: URL, cacheKey: string, isMutable: boolean): Promise<Response> {
const response = await fetchHandler({ path: url.pathname, request: event.request, event })
log.trace('got response from fetchHandler')

Expand All @@ -417,7 +417,7 @@ async function fetchAndUpdateCache (event: FetchEvent, url: URL, cacheKey: strin
log('response status: %s', response.status)

try {
await storeReponseInCache({ response, isMutable: true, cacheKey, event })
await storeReponseInCache({ response, isMutable, cacheKey, event })
log.trace('updated cache for %s', cacheKey)
} catch (err) {
log.error('failed updating response in cache for %s', cacheKey, err)
Expand All @@ -441,15 +441,15 @@ async function getResponseFromCacheOrFetch (event: FetchEvent): Promise<Response

if (isMutable) {
// If the response is mutable, update the cache in the background.
void fetchAndUpdateCache(event, url, cacheKey)
void fetchAndUpdateCache(event, url, cacheKey, isMutable)
}

return cachedResponse
}

log('cached response MISS for %s', cacheKey)

return fetchAndUpdateCache(event, url, cacheKey)
return fetchAndUpdateCache(event, url, cacheKey, isMutable)
}

function shouldCacheResponse ({ event, response }: { event: FetchEvent, response: Response }): boolean {
Expand Down