Skip to content

Commit 0eb323e

Browse files
Fixes deprecation overload for hanging quat_rotate calls in articulation and rigid_object_collection (#2867)
# Description Changes remaining quat_rotate calls to quat_apply calls. Fixes #2859 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Signed-off-by: Kelly Guo <kellyguo123@hotmail.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Kelly Guo <kellyguo123@hotmail.com>
1 parent 3692ace commit 0eb323e

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

source/isaaclab/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
# Note: Semantic Versioning is used: https://semver.org/
4-
version = "0.40.15"
4+
version = "0.40.16"
55

66
# Description
77
title = "Isaac Lab framework for Robot Learning"

source/isaaclab/docs/CHANGELOG.rst

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
Changelog
22
---------
33

4+
0.40.16 (2025-07-08)
5+
~~~~~~~~~~~~~~~~~~~~
6+
7+
Fixed
8+
^^^^^
9+
10+
* Fixed hanging quat_rotate calls to point to quat_apply in :class:`~isaaclab.assets.articulation.ArticulationData` and
11+
:class:`~isaaclab.assets.articulation.RigidObjectCollectionData`
12+
13+
414
0.40.15 (2025-07-08)
515
~~~~~~~~~~~~~~~~~~~~
616

source/isaaclab/isaaclab/assets/articulation/articulation_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ def root_link_vel_w(self) -> torch.Tensor:
406406
vel = self.root_com_vel_w.clone()
407407
# adjust linear velocity to link from center of mass
408408
vel[:, :3] += torch.linalg.cross(
409-
vel[:, 3:], math_utils.quat_rotate(self.root_link_quat_w, -self.body_com_pos_b[:, 0]), dim=-1
409+
vel[:, 3:], math_utils.quat_apply(self.root_link_quat_w, -self.body_com_pos_b[:, 0]), dim=-1
410410
)
411411
# set the buffer data and timestamp
412412
self._root_link_vel_w.data = vel
@@ -522,7 +522,7 @@ def body_link_vel_w(self) -> torch.Tensor:
522522
velocities = self.body_com_vel_w.clone()
523523
# adjust linear velocity to link from center of mass
524524
velocities[..., :3] += torch.linalg.cross(
525-
velocities[..., 3:], math_utils.quat_rotate(self.body_link_quat_w, -self.body_com_pos_b), dim=-1
525+
velocities[..., 3:], math_utils.quat_apply(self.body_link_quat_w, -self.body_com_pos_b), dim=-1
526526
)
527527
# set the buffer data and timestamp
528528
self._body_link_vel_w.data = velocities

source/isaaclab/isaaclab/assets/rigid_object_collection/rigid_object_collection_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def object_link_vel_w(self):
152152
velocity = self.object_com_vel_w.clone()
153153
# adjust linear velocity to link from center of mass
154154
velocity[..., :3] += torch.linalg.cross(
155-
velocity[..., 3:], math_utils.quat_rotate(self.object_link_quat_w, -self.object_com_pos_b), dim=-1
155+
velocity[..., 3:], math_utils.quat_apply(self.object_link_quat_w, -self.object_com_pos_b), dim=-1
156156
)
157157
# set the buffer data and timestamp
158158
self._object_link_vel_w.data = velocity

0 commit comments

Comments
 (0)