Skip to content

Commit 47854e7

Browse files
added stripping of doc strings + units here and here
1 parent 9afde96 commit 47854e7

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

source/isaaclab/isaaclab/envs/mdp/observations.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ def body_projected_gravity_b(
184184
"""
185185

186186

187-
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape])
187+
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape], units="rad")
188188
def joint_pos(env: ManagerBasedEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("robot")) -> torch.Tensor:
189189
"""The joint positions of the asset.
190190
@@ -195,7 +195,7 @@ def joint_pos(env: ManagerBasedEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("
195195
return asset.data.joint_pos[:, asset_cfg.joint_ids]
196196

197197

198-
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape])
198+
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape], units="rad")
199199
def joint_pos_rel(env: ManagerBasedEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("robot")) -> torch.Tensor:
200200
"""The joint positions of the asset w.r.t. the default joint positions.
201201
@@ -223,7 +223,7 @@ def joint_pos_limit_normalized(
223223
)
224224

225225

226-
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape])
226+
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape], units="rad/s")
227227
def joint_vel(env: ManagerBasedEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("robot")):
228228
"""The joint velocities of the asset.
229229
@@ -234,7 +234,7 @@ def joint_vel(env: ManagerBasedEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("
234234
return asset.data.joint_vel[:, asset_cfg.joint_ids]
235235

236236

237-
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape])
237+
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape], units="rad/s")
238238
def joint_vel_rel(env: ManagerBasedEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("robot")):
239239
"""The joint velocities of the asset w.r.t. the default joint velocities.
240240
@@ -245,7 +245,7 @@ def joint_vel_rel(env: ManagerBasedEnv, asset_cfg: SceneEntityCfg = SceneEntityC
245245
return asset.data.joint_vel[:, asset_cfg.joint_ids] - asset.data.default_joint_vel[:, asset_cfg.joint_ids]
246246

247247

248-
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape])
248+
@generic_io_descriptor(observation_type="JointState", on_inspect=[record_joint_names, record_dtype, record_shape], units="N.m")
249249
def joint_effort(env: ManagerBasedEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("robot")) -> torch.Tensor:
250250
"""The joint applied effort of the robot.
251251

source/isaaclab/isaaclab/envs/utils/io_descriptors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def wrapper(env: ManagerBasedEnv, *args: P.args, **kwargs: P.kwargs) -> R:
152152
descriptor.dtype = str(descriptor.dtype)
153153
# Check if description is set in the descriptor
154154
if descriptor.description is None:
155-
descriptor.description = func.__doc__
155+
descriptor.description = " ".join(func.__doc__.split())
156156

157157
# Adds the descriptor to the wrapped function as an attribute
158158
wrapper._descriptor = descriptor

source/isaaclab/isaaclab/managers/action_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def IO_descriptor(self) -> GenericActionIODescriptor:
9999
"""The IO descriptor for the action term."""
100100
self._IO_descriptor.name = re.sub(r"([a-z])([A-Z])", r"\1_\2", self.__class__.__name__).lower()
101101
self._IO_descriptor.full_path = f"{self.__class__.__module__}.{self.__class__.__name__}"
102-
self._IO_descriptor.description = self.__class__.__doc__
102+
self._IO_descriptor.description = " ".join(self.__class__.__doc__.split())
103103
return self._IO_descriptor
104104

105105
"""

0 commit comments

Comments
 (0)