Skip to content

Commit 8a913d0

Browse files
Uses --gpus instead of nvidia runtime for docker (#2411)
# Description Use `--gpus all` instead of `nvidia: runtime` to prevent issues on unknown or invalid runtime name when running with docker or docker compose (python script). Fixes #2390 ## Type of change - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update ## Screenshots N/A ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <kellyguo123@hotmail.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
1 parent fb4157e commit 8a913d0

File tree

3 files changed

+20
-3
lines changed

3 files changed

+20
-3
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ Guidelines for modifications:
106106
* Wei Yang
107107
* Xavier Nal
108108
* Yang Jin
109+
* Yanzi Zhu
109110
* Yujian Zhang
110111
* Zhengyu Zhang
111112
* Ziqi Fan

docker/docker-compose.cloudxr-runtime.patch.yaml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
services:
22
cloudxr-runtime:
33
image: ${CLOUDXR_RUNTIME_BASE_IMAGE_ARG}:${CLOUDXR_RUNTIME_VERSION_ARG}
4-
runtime: nvidia
54
ports:
65
- "48010:48010/tcp" # signaling
76
- "47998:47998/udp" # media
@@ -20,16 +19,29 @@ services:
2019
- ACCEPT_EULA=${ACCEPT_EULA}
2120
volumes:
2221
- openxr-volume:/openxr:rw
22+
deploy:
23+
resources:
24+
reservations:
25+
devices:
26+
- driver: nvidia
27+
count: all
28+
capabilities: [ gpu ]
2329

2430
isaac-lab-base:
25-
runtime: nvidia
2631
environment:
2732
- XDG_RUNTIME_DIR=/openxr/run
2833
- XR_RUNTIME_JSON=/openxr/share/openxr/1/openxr_cloudxr.json
2934
volumes:
3035
- openxr-volume:/openxr:rw
3136
depends_on:
3237
- cloudxr-runtime
38+
deploy:
39+
resources:
40+
reservations:
41+
devices:
42+
- driver: nvidia
43+
count: all
44+
capabilities: [ gpu ]
3345

3446
volumes:
3547
openxr-volume:

docs/source/how-to/cloudxr_teleoperation.rst

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ There are two options to run the CloudXR Runtime Docker container:
185185
186186
docker run -it --rm --name cloudxr-runtime \
187187
--user $(id -u):$(id -g) \
188-
--runtime=nvidia \
188+
--gpus=all \
189189
-e "ACCEPT_EULA=Y" \
190190
--mount type=bind,src=$(pwd)/openxr,dst=/openxr \
191191
-p 48010:48010 \
@@ -197,6 +197,10 @@ There are two options to run the CloudXR Runtime Docker container:
197197
-p 48012:48012/udp \
198198
nvcr.io/nvidia/cloudxr-runtime:0.1.0-isaac
199199
200+
.. note::
201+
If you choose a particular GPU instead of ``all``, you need to make sure Isaac Lab also runs
202+
on that GPU.
203+
200204
#. In a new terminal where you intend to run Isaac Lab, export the following environment
201205
variables, which reference the directory created above:
202206

0 commit comments

Comments
 (0)