Fix Image Feature Extraction Observation by Removing Double Normalization and Using Only GPU Operations #1323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, image_features requested normalized images prior to normalizing as part of the preprocessing. As pointed out to me by Jinghuan Shang (Theia Vision Transformer first author), this lead to images being normalized more than once which is ineffective and incorrect. Furthermore, Jinghuan pointed out where Transformers needlessly converted from GPU to CPU for normalization, where these operations could be converted to be GPU only.
ALSO: Fixes device and setup.py
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there