Sets enable_stabilization to false by default. #2628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyguo11
changed the title
|
test_rigid_object.py seems to be failing, could you check if it's passing locally? |
Mayankm96
reviewed
Jun 23, 2025
|
|
||
| .. note:: | ||
|
|
||
| Setting this flag to True should only be done if the simulation steps are very large (less than 30Hz). |
There was a problem hiding this comment.
Should we throw a warning about this finding from the code? This way users know that if they see some issues in forces, they have a heads up?
There was a problem hiding this comment.
Agreed, I added a warning if the dt is large and stabilization is disabled.
Mayankm96
reviewed
Jun 23, 2025
Mayankm96
reviewed
Jun 23, 2025
AntoineRichard
force-pushed
the
antoiner/disable_stabilization_by_default
branch
from
04b65c7 to
b28089d
Compare
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Antoine RICHARD <antoiner@nvidia.com>
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Antoine RICHARD <antoiner@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the default setting for the enable stabilization flag from True to False.
Fixes #2319
Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there