-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update documentation on pytorch multi gpu setup #2687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/source/features/multi_gpu.rst
Outdated
The key components in this setup are: | ||
|
||
* **Torchrun**: Handles process spawning, communication, and gradient synchronization. | ||
* **RL Games**: The reinforcement learning framework that runs the actual training algorithm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multi-GPU is not specific to RL Games, SKRL and RSL RL both support it as well. we can maybe rename this to RL Library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it's still saying "RL Games"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, I updated the docs here to refer to this as "RL Library"
Description
Update the Multi GPU documentation to include more information about how we integrate with Pytorch and include more documentation links.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there