-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fixes missing ray_cast_drift
in RayCasterCamera
#2901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes missing ray_cast_drift
in RayCasterCamera
#2901
Conversation
@jsmith-bdai and @ooctipus would be great to get some quick eyes on that as #2556 breaks the raycaster camera |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM sorry about the break.
The changes looks good to me, thank you Pascal for catching that. |
thanks for catching the fix! it does seem like the ID flexibilities have been hitting us in a couple of places recently, we should consider the design for Newton as well and see what makes sense to support. |
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyguo123@hotmail.com>
I agree @kellyguo11 and @ooctipus, we should introduce tests for the cases. |
Description
Fixes missing
ray_cast_drift
inRayCasterCamera
Fixes #2891
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there