do not suspend in useResult for components #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykWalach
force-pushed
the
not-suspend-in-useResult-for-components
branch
2 times, most recently
from
32f9a9b to
674f20d
Compare
PatrykWalach
commented
Nov 7, 2025
PatrykWalach
force-pushed
the
not-suspend-in-useResult-for-components
branch
4 times, most recently
from
176d077 to
74d65ce
Compare
PatrykWalach
commented
Nov 7, 2025
| ], | ||
| entrypoint: { | ||
| kind: "EntrypointLoader", | ||
| typeAndField: "BlogItem__BlogItemMoreDetail", |
Member
Author
There was a problem hiding this comment.
I guess here we want the abstract type and the concrete:
- abstract to cache
.loader() - concrete for the fragment
PatrykWalach
commented
Nov 7, 2025
| fragmentReference.readerWithRefetchQueries, | ||
| ); | ||
|
|
||
| switch (readerWithRefetchQueries.readerArtifact.kind) { |
Member
Author
There was a problem hiding this comment.
I guess I've missed an important fact - the kind of resolver needs to be known upfront
PatrykWalach
force-pushed
the
not-suspend-in-useResult-for-components
branch
from
c542fbf to
d171aed
Compare
PatrykWalach
commented
Nov 7, 2025
| const isographArtifactPromiseWrapper = getOrLoadIsographArtifact( | ||
| environment, | ||
| field.entrypoint.typeAndField, | ||
| `${root.__typename}/${field.entrypoint.fieldName}`, |
PatrykWalach
force-pushed
the
not-suspend-in-useResult-for-components
branch
from
7be4765 to
5b1706d
Compare
PatrykWalach
force-pushed
the
not-suspend-in-useResult-for-components
branch
from
5b1706d to
61b97df
Compare
PatrykWalach
force-pushed
the
not-suspend-in-useResult-for-components
branch
from
61b97df to
c213e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #746
This is part 2 of 2 in a stack made with GitButler: