Skip to content

Commit 0cca728

Browse files
authored
Merge pull request #8 from ississippi/decisions-testing
Logging cleanup, favicon
2 parents 05cb0e0 + db6c968 commit 0cca728

File tree

6 files changed

+5
-304
lines changed

6 files changed

+5
-304
lines changed

CloudFormation/parameters.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

CloudFormation/template.yaml

Lines changed: 0 additions & 284 deletions
This file was deleted.

NotificationsService/NotificationsService/Controllers/PrController.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public async Task<IActionResult> GetOpenPrs()
7474
}
7575
}
7676

77-
_logger.LogInformation($"Successfully processed {processedReviews.Count} reviews");
77+
_logger.LogDebug($"Successfully processed {processedReviews.Count} reviews");
7878
return Ok(processedReviews);
7979
}
8080
catch (Exception ex)
@@ -140,7 +140,7 @@ public IActionResult PostFeedback([FromBody] FeedbackRequest request)
140140
_logger.LogDebug($"Received feedback: PR#{request.prNumber}, Vote: {request.vote}");
141141
//Console.WriteLine($"Received feedback: PR#{request.PrNumber}, Vote: {request.Vote}");
142142

143-
return Ok(new { message = "Feedback received" });
143+
return Ok(new { message = "Feedback received by the Notifications Service" });
144144
}
145145

146146
// 4. POST action decision (Approve or Request Changes)
@@ -149,7 +149,7 @@ public IActionResult PostReview([FromBody] DecisionRequest request)
149149
{
150150
_logger.LogDebug($"Received decision: PR#{request.prNumber}, Decision: {request.decision}");
151151
// call the git service to submit the decision to Git
152-
return Ok(new { message = "Decision received" });
152+
return Ok(new { message = "Decision received by the Notifications Service" });
153153
}
154154
public object GetPrItemDetails(Dictionary<string, AttributeValue> prItem)
155155
{

NotificationsService/NotificationsService/Services/PrService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -553,14 +553,14 @@ private async Task SimulateNewPrs()
553553
// Implement IDisposable to properly clean up resources
554554
public void Dispose()
555555
{
556-
_logger.LogInformation($"Entered dispose-1");
556+
_logger.LogDebug($"Entered dispose-1");
557557
Dispose(true);
558558
GC.SuppressFinalize(this);
559559
}
560560

561561
protected virtual void Dispose(bool disposing)
562562
{
563-
_logger.LogInformation($"Entered dispose-2");
563+
_logger.LogDebug($"Entered dispose-2");
564564
if (_disposed) return;
565565

566566
if (disposing)
15 KB
Binary file not shown.

favicon.png

1.07 MB
Loading

0 commit comments

Comments
 (0)