-
Notifications
You must be signed in to change notification settings - Fork 130
Implement checkpoints usage in local #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ilongin
wants to merge
66
commits into
main
Choose a base branch
from
ilongin/1361-local-checkpoints-usage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 49 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
de9e0de
added logic to skip applying chain if checkpoint exist
ilongin 4f5f304
removed not needed code
ilongin a0ad1b8
adding prints
ilongin 2aae374
removed prints
ilongin b1df328
added job manager
ilongin b9c2020
added tests for util function to get user code
ilongin d0a4129
using job manager and adding unit tests for it
ilongin f66dc53
refactor
ilongin 0921aea
made reset checkpoints as default for now
ilongin ea34286
added job manager reset and refactoring test_checkpoints to use new j…
ilongin f19a055
refactoring, fixing tests
ilongin 33a2bcd
adding job e2e tests
ilongin 9988d8c
refactoring tests
ilongin fecdcae
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 4ea1169
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin b9d748a
fix
ilongin 2f806ca
fixig tests
ilongin 01d0711
fixing job manager tests for keyboard interruption
ilongin 105b03b
fixing windows test
ilongin 0efc106
added more elements to hash
ilongin 5db18e5
fixing test
ilongin cbdcac2
removed JobManager and moved its logic to Session
ilongin dd2487d
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin b26b150
mergint with main
ilongin 09af752
removed saving query string in new job locally
ilongin f38fc70
merged with main
ilongin 99afaeb
moved reset_job_state to test from Session
ilongin b896d3c
moved get_last_job_by_name to sqlite metastore
ilongin 7d27879
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 18aa7c9
moved job to Session class attributes to ensure same job per process,…
ilongin 428e10d
making job name random in interactive runs
ilongin 84eebc7
refactoring except_hook
ilongin 0e09ce8
moved tests from test_datachain to test_job_management
ilongin a7ff56b
fixing issue with updating job state because of hook after db is cleaned
ilongin 8c006c8
fixing typing
ilongin c4f1b34
merging with main
ilongin 74a1106
fixing windows tests
ilongin b009a4a
more robust check if is script run
ilongin d3acdb0
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 2e924f2
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin fb9306b
using util function to clean hooks
ilongin 57d4845
removed session arg from reset_session_job_state
ilongin 813cbd5
added checkpoint test with parallel and fixed deregistering job hooks
ilongin 6ecf6b0
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 026996e
more granular exception check
ilongin b368d93
using better fixture
ilongin cedbabd
moved test_checkpoints_parallel to func tests
ilongin faee8ac
increasing number of rows in test
ilongin ee6d880
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 354185b
removing logic of removing datasets on job failure
ilongin 07d881e
moved function to abstract
ilongin ecf102f
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 44e738c
fix test
ilongin 76aba6c
adding docs and removing not needed abstract method
ilongin 1fabb7a
adding checkpoint docs link
ilongin 737a05a
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin ef80ca1
fixing docs
ilongin 38e2bfc
adding missing abstract method
ilongin 1167983
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 4237b88
fixing parsing parent job id
ilongin f374500
skipping hf tests
ilongin fdd533d
returning tests
ilongin c6f7266
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 24c6b36
Merge branch 'main' into ilongin/1361-local-checkpoints-usage
ilongin 77eafbc
fix test
ilongin 380f36f
merged with main
ilongin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.