Skip to content

Conversation

@olivhoenen
Copy link
Collaborator

@olivhoenen olivhoenen commented Oct 31, 2025

Additions

  • New BALANCE_OF_PLANT and BREEDING_BLANKET IDSs
  • Add Boron species to the SUMMARY IDS
  • Add state velocity structure in CORE_PROFILES and PLASMA_PROFILES
  • Add total ion density source term in CORE_SOURCES and PLASMA_SOURCES
  • Add a few power loss global quantities in the DISTRIBUTIONS IDS
  • Add b_field and em_force_density in the WALL IDS
  • Add overall coil geometry in PF_ACTIVE IDS
  • Add new global quantities in the PLASMA_INITIATION IDS
  • Add perpendicular pressure in the DISTRIBUTIONS IDS
  • Add validity signals in the THOMSON_SCATTERING IDS
  • Add Bidirectional Reflectance Distribution Function (BRDF) to the WALL IDS
  • Add a list of equivalent field probes in the MAGNETICS IDS
  • Extension of the NEUTRON_DIAGNOSTIC IDS
  • Add parallel direction for the GGD transport coefficients in the PLASMA_TRANSPORT IDS
  • Extensions to the EQUILIBRIUM and DISRUPTION IDS
  • Extension of the CHARGE_EXCHANGE IDS
  • Add constant plasma composition in the SUMMARY IDS
  • Add estimated central electron temperature to the CAMERA_X_RAYS IDS
  • Add sputtering coefficients dimensions in the WALL IDS (global quantities)
  • Extend the SUMMARY IDS with more disruption related quantities

Changes

  • Remove the DATASET_DESCRIPTION IDS (several fields merged into the SUMMARY IDS)
  • Restructuging of the EC_LAUNCHERS IDS
    • Add a mirror structure, move beam/o_mode_fraction under beam/polarization/o_mode_fraction, remove beam/mode
  • Restructuring of the BOLOMETER IDS
  • Restructuring of the CAMERA_IR IDS
  • Mark global_quantities/psi_axis as deprecated in equilibrium IDS
  • Corrected the notation of isotopes in the node descriptions in DISTRIBUTIONS, DISTRIBUTIONS_SOURCES and SPECTROMETER_VISIBLE IDS, and also in the DISTRIBUTION_SOURCE_IDENTIFIER names
    • Add alias and units in identifier lists (handling of aliases requires AL>=5.5 or IMAS-Python>=2.0.2)
  • Fix 4.0 missing renames of label nodes into name in the PLASMA_PROFILES and PLASMA_TRANSPORT IDSs
  • Fix 4.0 missing replacements of id or identifier by name (+ description string) in the FOCS, TF_COIL, LH_ANTENNAS, OPERATIONAL_INSTRUMENTATION and COILS_NON_AXISYMMETRIC IDSs
  • Fix 4.0 missing renames of _tor to _phi the suffix of toroidal vector components, affects the following IDSs: SPI, SAWTEETH, RUNAWAY_ELECTRONS, DISTRIBUTIONS, DISTRIBUTIONS_SOURCES, LH_ANTENNAS, B_FIELD_NON_AXISYMMETRIC, SPECTROMETER_VISIBLE

📚 Documentation preview 📚: https://imas-data-dictionary--164.org.readthedocs.build/en/164/

maarten-ic and others added 30 commits April 14, 2025 14:18
For security reasons, pull_request workflows triggered from forks don't
have write permissions, and therefore cannot comment on the PR.

A second workflow (triggered by workflow_run) with sufficient
permissions will take care of posting the comment now.
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
… numbers for the AoS from 100 to 20, to avoid to overload the size of the MDS+ backend
[issue-42] Renaming psi_axis into psi_magnetic axis in the equilibrium IDS
Add a list of toroidally redundant poloidal field probes in the MAGNETICS IDS
Add a new workflow that triggers on tag to:
- Built the release version of the Data Dictionary definitions XML.
- Create a commit to the IMAS-Data-Dictionaries repository with the
  updated definitions and any updates to the identifiers.
- Open a Pull Request to the IMAS-Data-Dictionaries repository.

N.B. the workflow needs a token with write access to the
IMAS-Data-Dictionaries repository, specifically for the "Contents" and
"Pull requests" permissions.
imbeauf and others added 7 commits November 5, 2025 11:56
…merging the breeding_blanket from the old ITER GIT repo
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

@imbeauf
Copy link
Collaborator

imbeauf commented Nov 5, 2025

You may also consider to include PR #170 and optionally PR #171 , requests that were submitted yesterday ...

@olivhoenen
Copy link
Collaborator Author

You may also consider to include PR #170 and optionally PR #171 , requests that were submitted yesterday ...

#171 definitely, as 4.1.0 brings restructured bolometer IDS. #170 can go in if we can address quickly #170 (comment)

@github-actions
Copy link

@olivhoenen
Copy link
Collaborator Author

Are we ready to tag now @SimonPinches @imbeauf ?

@olivhoenen
Copy link
Collaborator Author

What do you think about integrating the two remaining ongoing PRs ?

  • Issue-85: I talked to Guillaume yesterday and have updated the related PR, still needs review
  • IMAS-5328 (additions to gyrokinetics): I have the impression that the CI is happy, but I am not sure this includes the compilation of AL. Can this be tested?
    Of course, those two PRs are not essential for tag 4.1, but if they can be concluded rapidly it's worth including them.

IMAS-5328 is not good (apparently it was ok-ish with only IMAS-5328, but not after it is applied on top of current develop with more changes to the gyrokinetics_local IDS).

I doubt that #85 can be reviewed/merged quickly, and it's probably not that urgent, so I wouldn't wait for it and prefer to release 4.1.0 as is (there are quite a lot of changes), unless @prasad-sawantdesai raises concerns from tests on it.

@imbeauf
Copy link
Collaborator

imbeauf commented Nov 14, 2025

Ok, so let's go for 4.1.0 as is it now !

@github-actions
Copy link

@maarten-ic
Copy link
Collaborator

Is it expected that DD 4.1 is about 50% bigger than 4.0?

When building the IDSDef.xml for this branch, it is about 30MB, whereas DD 4.0.0 was only 20MB.

@olivhoenen
Copy link
Collaborator Author

Is it expected that DD 4.1 is about 50% bigger than 4.0?

When building the IDSDef.xml for this branch, it is about 30MB, whereas DD 4.0.0 was only 20MB.

While there are 2 additional IDS, I guess most of this increase is related to the edge GGD structure being duplicated (while it was previously defined in edge_profiles and plasma_profiles, it's now defined in utilities and linked to the two IDSs, but in the final IDSDef.xml everything is inlined, so the same big structures is now in 3 different places instead of 2...)

@olivhoenen olivhoenen merged commit 90f446e into main Nov 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants