-
Notifications
You must be signed in to change notification settings - Fork 15
Release 4.1.0 #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.1.0 #164
Conversation
For security reasons, pull_request workflows triggered from forks don't have write permissions, and therefore cannot comment on the PR. A second workflow (triggered by workflow_run) with sufficient permissions will take care of posting the comment now.
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
… numbers for the AoS from 100 to 20, to avoid to overload the size of the MDS+ backend
…coordinate of the physical quantity is 1...N
[issue-42] Renaming psi_axis into psi_magnetic axis in the equilibrium IDS
Add a list of toroidally redundant poloidal field probes in the MAGNETICS IDS
…e examples in `__init__.py`
…MA_TRANSPORT IDS (IMAS-5434) (#56)
Add a new workflow that triggers on tag to: - Built the release version of the Data Dictionary definitions XML. - Create a commit to the IMAS-Data-Dictionaries repository with the updated definitions and any updates to the identifiers. - Open a Pull Request to the IMAS-Data-Dictionaries repository. N.B. the workflow needs a token with write access to the IMAS-Data-Dictionaries repository, specifically for the "Contents" and "Pull requests" permissions.
…merging the breeding_blanket from the old ITER GIT repo
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
#171 definitely, as 4.1.0 brings restructured bolometer IDS. #170 can go in if we can address quickly #170 (comment) |
This is handled by the ReadTheDocs version switcher.
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
Co-authored-by: Simon Pinches <SimonPinches@users.noreply.github.com>
|
Are we ready to tag now @SimonPinches @imbeauf ? |
IMAS-5328 is not good (apparently it was ok-ish with only IMAS-5328, but not after it is applied on top of current develop with more changes to the gyrokinetics_local IDS). I doubt that #85 can be reviewed/merged quickly, and it's probably not that urgent, so I wouldn't wait for it and prefer to release 4.1.0 as is (there are quite a lot of changes), unless @prasad-sawantdesai raises concerns from tests on it. |
|
Ok, so let's go for 4.1.0 as is it now ! |
|
Is it expected that DD 4.1 is about 50% bigger than 4.0? When building the IDSDef.xml for this branch, it is about 30MB, whereas DD 4.0.0 was only 20MB. |
While there are 2 additional IDS, I guess most of this increase is related to the edge GGD structure being duplicated (while it was previously defined in |
Additions
b_fieldandem_force_densityin the WALL IDSChanges
mirrorstructure, movebeam/o_mode_fractionunderbeam/polarization/o_mode_fraction, removebeam/modealiasandunitsin identifier lists (handling of aliases requires AL>=5.5 or IMAS-Python>=2.0.2)labelnodes intonamein the PLASMA_PROFILES and PLASMA_TRANSPORT IDSsidoridentifierbyname(+descriptionstring) in the FOCS, TF_COIL, LH_ANTENNAS, OPERATIONAL_INSTRUMENTATION and COILS_NON_AXISYMMETRIC IDSs_torto_phithe suffix of toroidal vector components, affects the following IDSs: SPI, SAWTEETH, RUNAWAY_ELECTRONS, DISTRIBUTIONS, DISTRIBUTIONS_SOURCES, LH_ANTENNAS, B_FIELD_NON_AXISYMMETRIC, SPECTROMETER_VISIBLE📚 Documentation preview 📚: https://imas-data-dictionary--164.org.readthedocs.build/en/164/