MatParam: code cleanup + javadoc #2521
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
MatParamclass by introducing stricter type checking when setting values, encapsulating type validation logic, and improving code readability and maintainability.It adds a dedicated
validateValueTypemethod, updates theequalsmethod for clarity and correctness usingObjects.equals, and refines JavaDoc comments throughout the class.Additionally, variable naming is clarified, redundant or commented-out code is cleaned up, and direct field access (e.g.,
v2.xinstead ofv2.getX()) is used for conciseness.These changes aim to make the codebase more robust and easier to maintain.
Edit:
Fix #2523