Skip to content

Conversation

@Godin
Copy link
Member

@Godin Godin commented Jun 6, 2025

fetch-depth: 0
- name: 'Build'
run: ./render.sh
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a docker container here? Is it due to python 2? In this case I can try to upgrade the rendering script to python 3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchof

Why do we need a docker container here? Is it due to python 2?

Yes: its use was added in #92 because Python 2 was available in ubuntu-20.04 GitHub Actions image, but not available in ubuntu-24.04 and it can not be installed with https://github.com/actions/setup-python since Python 2 reached EOL a long time ago - https://www.python.org/doc/sunset-python-2/

In this case I can try to upgrade the rendering script to python 3.

And yes - it will be awesome to update to Python 3!
FYI to do so according to my quick experiment we need to update generator/genshi to the version that supports Python 3 and a few other adjustments in generator.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #98

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchof Cool! Thanks!
I propose to anyway review+merge this one first since it is ready and small one and will unblock publishing of actual snapshots to web site - without it we are deploying old snapshot, while #98 is bigger and will take me some time to review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No prob, I can rebase #98 afterwards.

@Godin Godin marked this pull request as ready for review June 11, 2025 09:21
@Godin Godin requested a review from marchof June 11, 2025 09:21
@Godin Godin enabled auto-merge (squash) June 11, 2025 22:40
@Godin Godin merged commit 51aebe1 into master Jun 13, 2025
2 checks passed
@Godin Godin deleted the snapshot branch June 13, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants