-
Couldn't load subscription status.
- Fork 6
Migrate to downloading JaCoCo snapshots from the Central Publisher Portal #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| fetch-depth: 0 | ||
| - name: 'Build' | ||
| run: ./render.sh | ||
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a docker container here? Is it due to python 2? In this case I can try to upgrade the rendering script to python 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a docker container here? Is it due to python 2?
Yes: its use was added in #92 because Python 2 was available in ubuntu-20.04 GitHub Actions image, but not available in ubuntu-24.04 and it can not be installed with https://github.com/actions/setup-python since Python 2 reached EOL a long time ago - https://www.python.org/doc/sunset-python-2/
In this case I can try to upgrade the rendering script to python 3.
And yes - it will be awesome to update to Python 3!
FYI to do so according to my quick experiment we need to update generator/genshi to the version that supports Python 3 and a few other adjustments in generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No prob, I can rebase #98 afterwards.
Part of jacoco/jacoco#1896
https://central.sonatype.org/publish/publish-portal-snapshots/#consuming-snapshot-releases-for-your-project