-
Notifications
You must be signed in to change notification settings - Fork 127
fixing mcp tool for windows #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @leonardommello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers crucial bug fixes and enhancements for the MCP tool, primarily focusing on improving its compatibility and operational stability on Windows systems. It addresses issues with command execution by adapting to platform-specific shell requirements and updates the interaction with the Gemini CLI to align with its latest argument syntax. Additionally, logging behavior has been optimized to prevent unintended output interference, and development dependencies have been cleaned up, contributing to a more robust and efficient tool. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the gemini-cli-mcp tool to version 1.1.5 with improvements to logging, CLI command syntax, and cross-platform compatibility.
Key Changes:
- Conditional debug logging to prevent interference with MCP stdio protocol in production
- Updated Gemini CLI command syntax to use positional arguments instead of
-pflag - Platform-specific shell configuration for better Windows support
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/logger.ts | Adds conditional logging based on DEBUG/NODE_ENV environment variables; only errors are always logged to avoid stdio interference |
| src/utils/geminiExecutor.ts | Updates CLI invocation to use positional arguments for prompts instead of -p flag, applied consistently to both main and fallback execution paths |
| src/utils/commandExecutor.ts | Implements platform-specific shell configuration (shell: true on Windows for .cmd/.bat support, shell: false on Unix for security) |
| src/index.ts | Version bump to 1.1.5 and code formatting improvements (separated statements onto individual lines) |
| package.json | Version bump to 1.1.5 and removal of unused nodemon dependency |
| package-lock.json | Removal of nodemon and its transitive dependencies (chokidar, anymatch, braces, etc.) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a fix for running the MCP tool on Windows by enabling the shell when spawning commands. It also updates the Gemini CLI command syntax to use a positional argument for the prompt and refactors the logging to be suppressible in production. The Windows fix is correct, but it introduces a potential security risk due to manual argument quoting in another file. Additionally, the logging changes have a bug where important warnings are suppressed in production, and the use of console.warn for all log levels is semantically confusing.
Description
Brief description of changes
Type of Change
Testing