Normalize voxel offset for Neuroglancer run viewer by voxel size#302
Open
atc3 wants to merge 4 commits intojanelia-cellmap:mainfrom
Open
Normalize voxel offset for Neuroglancer run viewer by voxel size#302atc3 wants to merge 4 commits intojanelia-cellmap:mainfrom
atc3 wants to merge 4 commits intojanelia-cellmap:mainfrom
Conversation
rhoadesScholar
approved these changes
Nov 8, 2024
Member
rhoadesScholar
left a comment
rhoadesScholar
left a comment
There was a problem hiding this comment.
Code looks good. @mzouink Can you test it out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the voxel offsets for the raw data and prediction labels in NeuroglancerRunViewer were in physical nanometer units instead of voxel units - and for me this produced volumes in neuroglancer that were totally offset from one another.
This PR normalizes the voxel offsets back to voxel space so that raw and label volumes are aligned