Add Linux support, Add local file support #21

janniks · 2020-03-21T22:11:40Z

If you'll allow it, I'd love to include some of your changes... ☺️

changed shebang from sh to bash

janniks

@yrave Love the changes so far 🚀 Let me know what you think...

janniks · 2020-03-21T22:12:17Z

scripts/install.sh

@@ -1,12 +1,13 @@
-#!/bin/sh
+#!/bin/bash


Is there a reason for the switch to bash ?

Or maybe @schnappfuesch can help 😊

The for-loop is using an invalid bracket syntax (((...))) for sh. The bash is a sh extension that understand this format. I'm also not sure if you can use the counter in the for-loop at all (using sh).
On most linuxe the sh is no longer directly installed but a replacement, which is linked to a different shell, so depending on the outcome of this link, the command might work (e.g. on ubuntu sh is linked to dash, which will fail).

If you pipe the script into sh using the curl command, you will also get this error:
Syntax error: Bad for loop variable.

A more portable solution would be

Suggested change

#!/bin/bash

#!/usr/bin/env bash

which works on all systems (including the more obscure ones like NixOS, where /bin/bash does not exist)

janniks · 2020-03-21T22:12:59Z

scripts/install.sh

 PLACEHOLDER_LOGGING_VERBOSE="true"
-
-GITHUB_SCRIPT_URL="https://raw.githubusercontent.com/janniks/prepare-commit-msg/master/scripts/prepare-commit-msg"
+PLACEHOLDER_NEW_COMMIT_MESSAGE="#{issue_number.upcase}: #{original_commit_message.gsub(/(\s[[:punct:]])+$/, '')}"


I like the idea of parameterizing the new commit message. I can also add this to the install script 👍

Thanks! That was actually the main reason why I forked your project

janniks · 2020-03-21T22:13:44Z

scripts/install.sh


-printf -- " - Downloading git hook...\n"
-curl -s "$GITHUB_SCRIPT_URL" > "$HOOK_FILE"
+if [ "$should_use_file_from_github_url" = true ] ; then


Also a very nice feature 🙌 I might also like to add this to the install script

Thanks :) I was too lazy to add it to the advanced option and I used it only for testing

janniks · 2020-03-21T22:13:56Z

scripts/install.sh

 	    exit
 	fi
-    
+


janniks · 2020-03-21T22:14:44Z

scripts/install.sh

+
+replace_placeholder_with_value () {
+	if [ $(uname -s) == "Linux" ]; then
+		sed -i "s/${1}/${2}/g" "$HOOK_FILE"


Good catch! Is this important/relevant for all Linux?

I’ve worked on other scripts that use the sed command and it’s been relevant for all Linux user.

yrave · 2020-03-21T23:11:55Z

If you'll allow it, I'd love to include some of your changes... ☺️

Yes, please, of course! And thank you for the script. It's been really helpful so far :)

yrave · 2020-05-06T12:33:21Z

I updated the script so that it can now use different message styles and different message regexes. Let me know what you think and if you want to merge it :)

janniks · 2021-01-30T08:09:17Z

Sorry for the delay! I want to merge this 🙈 I'll try in ~ 1-2 weeks, as I am a bit busy currently...

logrusorgru · 2025-01-25T21:09:15Z

README.md


 ```bash
-sh <(curl -s https://raw.githubusercontent.com/janniks/prepare-commit-msg/master/scripts/install.sh)
+sh <(curl -s https://raw.githubusercontent.com/yrave/prepare-commit-msg/master/scripts/install.sh)


Replaced in PR?

Suggested change

sh <(curl -s https://raw.githubusercontent.com/yrave/prepare-commit-msg/master/scripts/install.sh)

sh <(curl -s https://raw.githubusercontent.com/janniks/prepare-commit-msg/master/scripts/install.sh)

miallo · 2025-09-29T01:05:36Z

scripts/install.sh

@@ -1,12 +1,13 @@
-#!/bin/sh
+#!/bin/bash


A more portable solution would be

Suggested change

#!/bin/bash

#!/usr/bin/env bash

which works on all systems (including the more obscure ones like NixOS, where /bin/bash does not exist)

miallo · 2025-09-29T01:07:03Z

scripts/install.sh

+PLACEHOLDER_NEW_COMMIT_MESSAGE="[#{issue_number.upcase}] #{original_commit_message.gsub(/(\s[[:punct:]])+$/, '')}"
+PLACEHOLDER_NEW_COMMIT_MESSAGE_ONE="[#{issue_number.upcase}] #{original_commit_message.gsub(/(\s[[:punct:]])+$/, '')}"
+PLACEHOLDER_NEW_COMMIT_MESSAGE_TWO="#{issue_number.upcase}: #{original_commit_message.gsub(/(\s[[:punct:]])+$/, '')}"
+GITHUB_SCRIPT_URL="https://raw.githubusercontent.com/yrave/prepare-commit-msg/master/scripts/prepare-commit-msg"


Suggested change

GITHUB_SCRIPT_URL="https://raw.githubusercontent.com/yrave/prepare-commit-msg/master/scripts/prepare-commit-msg"

GITHUB_SCRIPT_URL="https://raw.githubusercontent.com/janniks/prepare-commit-msg/master/scripts/prepare-commit-msg"

miallo · 2025-09-29T01:07:23Z

README.md


 ```bash
-sh <(curl -s https://raw.githubusercontent.com/janniks/prepare-commit-msg/master/scripts/install.sh)
+sh <(curl -s https://raw.githubusercontent.com/yrave/prepare-commit-msg/master/scripts/install.sh)


Suggested change

sh <(curl -s https://raw.githubusercontent.com/yrave/prepare-commit-msg/master/scripts/install.sh)

sh <(curl -s https://raw.githubusercontent.com/janniks/prepare-commit-msg/master/scripts/install.sh)

yrave and others added 7 commits March 12, 2020 19:53

Updated new commit message

f0b5a3b

Updated README.md

e297085

Added Github URL

a99d73d

changed shebang from sh to bash

b78bd34

Merge pull request #1 from schnappfuesch/master

8c04b33

changed shebang from sh to bash

Added different sed command for Linux

e72ebc7

Merge branch 'master' of https://github.com/yrave/prepare-commit-msg

c7b88f1

janniks commented Mar 21, 2020

View reviewed changes

Added choosable option for commit regex

87987c0

yrave force-pushed the master branch 4 times, most recently from c29738d to 68730b2 Compare May 6, 2020 11:45

Changed URL to correct repo

71f695d

yrave force-pushed the master branch from 68730b2 to 71f695d Compare May 6, 2020 11:46

Added choosable option for commit message style

469a85c

yrave previously approved these changes May 6, 2020

View reviewed changes

Update urls

9d9312e

yrave dismissed their stale review via 9d9312e January 27, 2021 13:10

logrusorgru reviewed Jan 25, 2025

View reviewed changes

miallo reviewed Sep 29, 2025

View reviewed changes

	sh <(curl -s https://raw.githubusercontent.com/yrave/prepare-commit-msg/master/scripts/install.sh)
	sh <(curl -s https://raw.githubusercontent.com/janniks/prepare-commit-msg/master/scripts/install.sh)

	GITHUB_SCRIPT_URL="https://raw.githubusercontent.com/yrave/prepare-commit-msg/master/scripts/prepare-commit-msg"
	GITHUB_SCRIPT_URL="https://raw.githubusercontent.com/janniks/prepare-commit-msg/master/scripts/prepare-commit-msg"

Add Linux support, Add local file support #21

Are you sure you want to change the base?

Add Linux support, Add local file support #21

Uh oh!

Conversation

janniks commented Mar 21, 2020

Uh oh!

janniks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

schnappfuesch Mar 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yrave commented Mar 21, 2020

Uh oh!

yrave commented May 6, 2020

Uh oh!

janniks commented Jan 30, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

schnappfuesch Mar 22, 2020 •

edited

Loading