Skip to content

passReqToCallback slightly inconsistent with Express, doc update? #133

@dgolant

Description

@dgolant

Hi,

I just dealt with a minor annoyance for an hour, figured I would share in case it was valuable for docs. When passing the passReqToCallback argument to a strat, the "incoming" query params are accessible through req.params. In Express, query params come through on req.query. In the callback/handler in the google strategy, req.query stores a state and code key, which makes it seem as though req.query is being overwritten even when passReqToCallback is true. Happy to update docs as long as this confusion isn't based solely in my own denseness 👍 .

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions