set lastRun before running the function #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if its a long running function, the next run includes the function's running time
|
Any plans of merging this to master? |
|
up? this could solve the #16 issue also I think |
|
Oh, the branch cannot be merged, there are conflicts |
|
This one can be closed as I resubmitted the pull request in #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move lastRun=time.Now() to before running of the function.
Otherwise if it is after the function, the next running time will include the time it took the function to run.
This becomes an issue when using job.At(hh:mm), since if the function takes 15 minutes to run, next run will be at hh:(mm+15)