Add a failing test to demonstrate a bug#254
Closed
mjnaderi wants to merge 1 commit intojazzband:masterfrom
mjnaderi:master
Closed
Add a failing test to demonstrate a bug#254mjnaderi wants to merge 1 commit intojazzband:masterfrom mjnaderi:master
mjnaderi wants to merge 1 commit intojazzband:masterfrom
mjnaderi:master
Conversation
Contributor
Author
|
Another note: With Sqlite, the test fails with: With PostgreSql, the test fails with: |
Contributor
Author
WhyNotHugo
reviewed
Sep 30, 2017
|
|
||
| print(my_teams[0].user_profiles.all()) | ||
| print(my_teams[1].user_profiles.all()) | ||
| self.assertEqual(len(my_teams[0].user_profiles.all()), 3) |
Member
There was a problem hiding this comment.
This doesn't look right; you're not ordering you QuerySet, so the first result returned by the DB might be team2. It'll probably fail, occasionally.
Collaborator
|
This PR has been stuck in this state for the last day, so I have pulled the commits and am superceding it with #671 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We found a bug in our project, and after investigating, we found where it comes from. So I created a failing test based on our issue.
In this test, removing
prefetch_relatedfrom this line:or removing this "for" loop:
resolves the issue, and test passes. But with both of them, test fails.