Django 5.1+ compatibility for PolymorphicQuerySet._process_aggregate_args() #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Django v5.1, django.db.models.Aggregate.get_source_expressions() can have None as item in the returned list, causing the final assert to fail
for more information, see https://pre-commit.ci
LeGast00n
changed the title
|
@LeGast00n Your MR looks very nice. i was running into this error myself on Django 5.2. Could you maybe fix the failing ruff check, so it can be merged? @bckohan IS anything else needed to get this merged? |
|
@khink @LeGast00n a test would be very helpful! |
khink
pushed a commit
to fourdigits/django-polymorphic
that referenced
this pull request
May 1, 2025
Since Django v5.1, django.db.models.Aggregate.get_source_expressions() can have None as item in the returned list, causing the final assert to fail This patch provided by LeGast00n in jazzband#629
|
superseded by #638 |
bckohan
pushed a commit
that referenced
this pull request
May 1, 2025
Since Django v5.1, django.db.models.Aggregate.get_source_expressions() can have None as item in the returned list, causing the final assert to fail This patch provided by LeGast00n in #629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Django v5.1, django.db.models.Aggregate.get_source_expressions() can have None as item in the returned list, causing the final assert to fail.