Skip to content

Add a regression test for polymorphic iteration#671

Merged
bckohan merged 1 commit intomasterfrom
mjnaderi/master
Dec 3, 2025
Merged

Add a regression test for polymorphic iteration#671
bckohan merged 1 commit intomasterfrom
mjnaderi/master

Conversation

@bckohan
Copy link
Copy Markdown
Collaborator

@bckohan bckohan commented Dec 3, 2025

  • regenerate migrations, fix test
  • remove prints
  • move test to regressions

PR #254 is broken, maybe because it is so old, I am superceding it with this PR.

Normally I wouldn't accept PRs like this but the user claims a regression and more is more with testing.

- regenerate migrations, fix test
- remove prints
- move test to regressions

Co-authored-by: Mohammad Javad Naderi <mjnaderi@gmail.com>
Co-authored-by: Brian Kohan <bckohan@gmail.com>
@bckohan bckohan changed the title - Add a regression test for polymorphic iteration Add a regression test for polymorphic iteration Dec 3, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.71%. Comparing base (9399f7d) to head (2d6f9f0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files          21       21           
  Lines        1337     1337           
  Branches      211      211           
=======================================
  Hits          999      999           
  Misses        261      261           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bckohan bckohan merged commit 9cb89d9 into master Dec 3, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants