Add a regression test for polymorphic iteration#671
Merged
Conversation
- regenerate migrations, fix test - remove prints - move test to regressions Co-authored-by: Mohammad Javad Naderi <mjnaderi@gmail.com> Co-authored-by: Brian Kohan <bckohan@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
=======================================
Coverage 74.71% 74.71%
=======================================
Files 21 21
Lines 1337 1337
Branches 211 211
=======================================
Hits 999 999
Misses 261 261
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #254 is broken, maybe because it is so old, I am superceding it with this PR.
Normally I wouldn't accept PRs like this but the user claims a regression and more is more with testing.