configure more than one http/s ports #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
jcmoraisjr
force-pushed
the
jm-frontends
branch
from
e51f008 to
590aa48
Compare
Adds the ability to configure the HTTP/s frontends with more than one HTTP port, allowing to multiplex distinct groups of hostnames without colliding each other. This is a pre-requisite to improve Gateway API support. Several places of HAProxy Ingress code uses the dual and plain HTTP/s model as a premise, so this is a non trivial refactor. Starting the refactor from the top of the internal HAProxy model representation. TODO list includes: * [x] Move Hosts and Frontend types under a new Frontends type * [x] Improve PathLink type to support distinct Frontends * [ ] Move Bind configurations specific to frontends under the Frontend type * [ ] Split the single HTTP/s frontend representation into two separated HTTP and HTTPs entries * [ ] Support a list of HTTP/s frontends * [ ] Add frontends support into Ingress API * [ ] Add listener.Port support into Gateway API
HAProxy model is defined with a single frontend entity, and a single list of hostnames representing both http and https entries. From this update, a list of frontends is supported, each of them being either http or https, and their hostnames represent only one of those protocols. So, a single ingress resource that uses to represent both http and https, now should add its hostname both http and https scoped frontends.
jcmoraisjr
force-pushed
the
jm-frontends
branch
from
590aa48 to
7f4dfd2
Compare
jcmoraisjr
force-pushed
the
jm-frontends
branch
from
7f4dfd2 to
dbe3048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure the HTTP/s frontends with more than one HTTP port, allowing to multiplex distinct groups of hostnames without colliding each other. This is a pre-requisite to improve Gateway API support.
Several places of HAProxy Ingress code uses the dual and plain HTTP/s model as a premise, so this is a non trivial refactor. Starting the refactor from the top of the internal HAProxy model representation.
Minimum HAProxy version changed from 2.4 to 2.6 -- added
set-var-fmt()action.TODO list includes: