Support nested schemas #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we didn't support repetition levels previously, this hadn't been tested. But we were reading the levels in the wrong order.
Rather than flattening schemas and adding a '.' between paths
in the schema (e.g. `foo.bar`), support the schema path as a
first-class object (for schema operations, at least). This
is an experimental implementation and likely has bugs. But it
supports some simple cases.
This implementation changes behavior. Specifically:
* `DictReader()` now has a `flatten` argument that defaults to
`False`. If Flatten is false, DictReader will read nested data
as `{'foo': {'bar': 1}}` instead of as `{'foo.bar': 1}`.
* Likewise, this is the new default behavior for the command-line
tool with `--format json`. This can be changed with `--flatten`.
Known issues:
* Repetition-levels still aren't supported. A file with arrays
will break.
* nulls aren't interpretted at the level. (e.g.: `{"foo": null}`
will be interpetted as `{"foo": {"bar": null}}` if `foo` has
a child of `bar`.
Refs: #32
|
"Read repetition levels before definition levels." - thank you for pointing this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than flattening schemas and adding a '.' between paths
in the schema (e.g.
foo.bar), support the schema path as afirst-class object (for schema operations, at least). This
is an experimental implementation and likely has bugs. But it
supports some simple cases.
This implementation changes behavior. Specifically:
DictReader()now has aflattenargument that defaults toFalse. If Flatten is false, DictReader will read nested dataas
{'foo': {'bar': 1}}instead of as{'foo.bar': 1}.tool with
--format json. This can be changed with--flatten.Known issues:
will break.
{"foo": null}will be interpetted as
{"foo": {"bar": null}}iffoohasa child of
bar.Refs: #32