Skip to content

Commit 774ddc2

Browse files
authored
Merge pull request #5498 from jdi-testing/5340
#5362 add tasks
2 parents 3162045 + f98744f commit 774ddc2

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

jdi-light-material-ui-tests/src/main/java/io/github/com/pages/feedback/ProgressPage.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ public class ProgressPage extends WebPage {
1313
@JProgress(root = "#circularIndeterminateProgress")
1414
public static CircularProgress circularProgressIndeterminate;
1515

16-
// @todo #5297 Check locators with aria-valuenow, very stange to use them
1716
@JProgress(root = "div[aria-valuenow='25'][1]")
1817
public static CircularProgress circularProgressDeterminateWithValue25;
1918

@@ -26,7 +25,7 @@ public class ProgressPage extends WebPage {
2625
@JProgress(root = "div[aria-valuenow='100'][1]")
2726
public static CircularProgress circularProgressDeterminateWithValue100;
2827

29-
@JProgress(root = "div[aria-valuenow='100'] ~ div[1]")
28+
@JProgress(root = "div[role='progressbar'][6]")
3029
public static CircularProgress circularProgressDeterminate;
3130

3231
@JProgress(root = "div[role='progressbar'][7]")
@@ -44,10 +43,13 @@ public class ProgressPage extends WebPage {
4443
@JProgress(root = "button.MuiButton-containedPrimary ~ div")
4544
public static CircularProgress acceptTermsCircularProgress;
4645

46+
// @todo #5340 Label is not a part of CurcularProgress, should be removed
4747
@JProgress(root = "(//h2[text()='Circular with label']/following::div[@role='progressbar'])[1]",
4848
label = "div.MuiTypography-caption")
4949
public static CircularProgress circularProgressWithLabel;
5050

51+
// @todo #5340 there is no first and second, there is a buffer and main progress,
52+
// should be renamed
5153
@JProgress(root = "(//h2[text()='Linear indeterminate']/following::div)[2]",
5254
firstBar = ".MuiLinearProgress-bar1Indeterminate",
5355
secondBar = ".MuiLinearProgress-bar2Indeterminate")

jdi-light-material-ui-tests/src/test/java/io/github/epam/material/tests/feedback/ProgressTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,9 @@ public void circularDeterminateTest() {
6363

6464
circularProgressDeterminate.is().displayed().and().determinate();
6565
int valueNow = circularProgressDeterminate.getValueNow();
66-
timer.wait(() -> circularProgressDeterminate.has().value(valueNow + 10));
66+
timer.wait(() -> circularProgressDeterminate.has().value((valueNow + 10) % 100));
6767

6868
circularProgressDeterminateIndeterminate.is().displayed().and().indeterminate();
69-
circularProgressDeterminateIndeterminate.circle()
70-
.has().cssClass("MuiCircularProgress-circleDisableShrink");
7169
}
7270

7371
@Test

jdi-light-material-ui/src/main/java/com/epam/jdi/light/material/annotations/JProgress.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import java.lang.annotation.RetentionPolicy;
1010
import java.lang.annotation.Target;
1111

12+
// @todo #5340 Check if this annotaion is needed
1213
/**
1314
* Annotation for setting custom locators for progress and its components.
1415
*

0 commit comments

Comments
 (0)