fix: Prevent PhotoSwipe script from wrapping already linked images #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the PhotoSwipe script wraps images that are already inside
<a>
tags, causing the original link functionality to be lost.Related Issue
Fixes #187
Problem
The PhotoSwipe script in
_includes/extensions/photo-swipe.html
currently wraps all<img>
elements (except those withemoji
class) in a new<a class="photo-swipe">
element. This includes images that are already wrapped in links, breaking their original functionality.Before (buggy behavior):
The original link to
https://example.com
becomes inaccessible.Solution
Added a check to skip images whose parent element is already an
<a>
tag, preserving their original link behavior.After this fix:
Changes
el.parentElement?.tagName.toLowerCase() === "a"
to skip images that are already inside anchor tagsTesting
emoji
class continue to be ignored as beforeFiles Changed
_includes/extensions/photo-swipe.html