tx_builder: fix spent output index error

jeffro256 · jeffro256 · commit 0174cff0d22c · 2025-06-18T16:36:39.000+02:00
diff --git a/src/wallet/tx_builder.cpp b/src/wallet/tx_builder.cpp
@@ -303,7 +303,8 @@ std::vector<carrot::InputCandidate> collect_carrot_input_candidate_list(
     for (std::size_t i = 0; i < transfers.size(); ++i)
     {
         const wallet2_basic::transfer_details &td = transfers.at(i);
-        if (best_transfer_by_ota.at(td.get_public_key()) != i)
+        const auto best_it = best_transfer_by_ota.find(td.get_public_key());
+        if (best_it == best_transfer_by_ota.cend() || best_it->second != i)
             continue;
 
         if (!is_transfer_usable_for_input_selection(td,

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,8 @@ std::vector<carrot::InputCandidate> collect_carrot_input_candidate_list(`
`303`	`303`	`for (std::size_t i = 0; i < transfers.size(); ++i)`
`304`	`304`	`{`
`305`	`305`	`const wallet2_basic::transfer_details &td = transfers.at(i);`
`306`		`- if (best_transfer_by_ota.at(td.get_public_key()) != i)`
	`306`	`+ const auto best_it = best_transfer_by_ota.find(td.get_public_key());`
	`307`	`+ if (best_it == best_transfer_by_ota.cend() \|\| best_it->second != i)`
`307`	`308`	`continue;`
`308`	`309`
`309`	`310`	`if (!is_transfer_usable_for_input_selection(td,`