vtnerd review 2025

jeffro256 · jeffro256 · commit c6f2ccdeb12b · 2025-01-28T13:24:23.000-06:00
diff --git a/src/cryptonote_core/blockchain.cpp b/src/cryptonote_core/blockchain.cpp
@@ -2082,7 +2082,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id
       const blobdata &tx_blob = extra_block_tx.second.second;
 
       tx_verification_context tvc{};
-      if ((!m_tx_pool.have_tx(txid, relay_category::all) &&
+      if ((!m_tx_pool.have_tx(txid, relay_category::legacy) &&
           !m_db->tx_exists(txid) &&
           !m_tx_pool.add_tx(tx, tvc, relay_method::block, /*relayed=*/true, hf_version, hf_version))
           || tvc.m_verifivation_failed)
@@ -5463,7 +5463,7 @@ void Blockchain::notify_txpool_event(std::vector<txpool_event>&& event)
   {
     try
     {
-      m_txpool_notifier(event);
+      m_txpool_notifier(std::move(event));
     }
     catch (const std::exception &e)
     {

Original file line number	Diff line number	Diff line change
`@@ -2082,7 +2082,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id`
`2082`	`2082`	`const blobdata &tx_blob = extra_block_tx.second.second;`
`2083`	`2083`
`2084`	`2084`	`tx_verification_context tvc{};`
`2085`		`- if ((!m_tx_pool.have_tx(txid, relay_category::all) &&`
	`2085`	`+ if ((!m_tx_pool.have_tx(txid, relay_category::legacy) &&`
`2086`	`2086`	`!m_db->tx_exists(txid) &&`
`2087`	`2087`	`!m_tx_pool.add_tx(tx, tvc, relay_method::block, /relayed=/true, hf_version, hf_version))`
`2088`	`2088`	`\|\| tvc.m_verifivation_failed)`
`@@ -5463,7 +5463,7 @@ void Blockchain::notify_txpool_event(std::vector<txpool_event>&& event)`
`5463`	`5463`	`{`
`5464`	`5464`	`try`
`5465`	`5465`	`{`
`5466`		`- m_txpool_notifier(event);`
	`5466`	`+ m_txpool_notifier(std::move(event));`
`5467`	`5467`	`}`
`5468`	`5468`	`catch (const std::exception &e)`
`5469`	`5469`	`{`