Skip to content

Add .html to archive file names without extension#127

Closed
Exagone313 wants to merge 1 commit intojekyll:masterfrom
Exagone313:fix-add-dot-html
Closed

Add .html to archive file names without extension#127
Exagone313 wants to merge 1 commit intojekyll:masterfrom
Exagone313:fix-add-dot-html

Conversation

@Exagone313
Copy link
Copy Markdown

Fixes #102.

Read carefully before merging, this may break some configurations, I need your feedback.
Also this is the first time I'm writing Ruby.

@Exagone313
Copy link
Copy Markdown
Author

Exagone313 commented Jun 3, 2018

Hmm, the commit message may not be good as I'm checking for \.html$ and not if there isn't an extension.

@ashmaroli
Copy link
Copy Markdown
Member

@Exagone313 Are you still interested in getting this merged..?

@Exagone313
Copy link
Copy Markdown
Author

It requires some changes but I still want to fix the underlying issue I created.

@ashmaroli
Copy link
Copy Markdown
Member

Okay. Apart from amending the original commit message (git commit --amend), you may want to check the source code for Jekyll::Page#destination and Jekyll::Document#destination for logic reference.

@Exagone313
Copy link
Copy Markdown
Author

I don't have time to work on this PR, I'm closing it.

@Exagone313 Exagone313 closed this Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically add .html to generated archives names without extension

2 participants