Skip to content

Restore BitbucketEndpointConfiguration.normalizeServerUrl() for compatibility #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarkEWaite
Copy link
Contributor

Restore BitbucketEndpointConfiguration.normalizeServerUrl() for compatibility

Blue Ocean Bitbucket plugin depends on this plugin and uses the BitbucketEndpointConfiguration.normalizeServerUrl method. Rather than require a new release of Blue Ocean, let's retain compatibility by restoring that method and marking it as deprecated.

Detected in:

Testing done:

mvn -Dtest=BitbucketSCMNavigatorTest,BitbucketEndpointConfigurationTest,BitbucketServerEndpointTest,BitbucketSCMNavigatorTest clean verify

Will use the incremental build of this pull request in:

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

…tibility

Blue Ocean Bitbucket plugin depends on this plugin and uses the
BitbucketEndpointConfiguration.normalizeServerUrl method.  Rather than
require a new release of Blue Ocean, let's retain compatibility by
restoring that method and marking it as deprecated.

Detected in:

* jenkinsci/bom#5076
* jenkinsci/bom#5088

Testing done:

mvn -Dtest=BitbucketSCMNavigatorTest,BitbucketEndpointConfigurationTest,BitbucketServerEndpointTest,BitbucketSCMNavigatorTest clean verify
@MarkEWaite
Copy link
Contributor Author

@nfalco79 it would be a great help if this could be merged and released promptly so that the most recent release of Bitbucket Branch Source plugin can be included in the Jenkins plugin BOM.

@nfalco79
Copy link
Member

Hi @MarkEWaite also if BitbucketEndpointConfiguration is not API (as documented in the README.ME) I merge and release.
After that I will create public classes in the api package to manage endpoint and remove the reference to non api classes in the (obsolete) blue ocean plugin with a PR that I hope you can push for the merge

@nfalco79 nfalco79 merged commit df5b2c4 into jenkinsci:master May 25, 2025
19 checks passed
@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented May 25, 2025

Hi @MarkEWaite also if BitbucketEndpointConfiguration is not API (as documented in the README.ME) I merge and release.

Thanks very much for the merge and release. Included in the plugin BOM with:

@MarkEWaite MarkEWaite deleted the retain-compatibility-for-other-plugins branch May 25, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants