Add API classes to manage bitbucket endpoints and hide the internal implementations #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...n/java/com/cloudbees/jenkins/plugins/bitbucket/api/endpoint/BitbucketEndpointDescriptor.java
Fixed
Show fixed
Hide fixed
nfalco79
force-pushed
the
feature/endpoint-api
branch
5 times, most recently
from
90d40c3 to
1f1deb7
Compare
nfalco79
force-pushed
the
feature/endpoint-api
branch
6 times, most recently
from
302e131 to
fd91e00
Compare
nfalco79
force-pushed
the
feature/endpoint-api
branch
from
fd91e00 to
3352e67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is add new API interfaces to manage bitbucket endpoints and their configurations transparent instead of rely to internal methods that must be protected against external use of the when changes because was not intended to be accessible from other plugin we have to revert changes.
These new API will be used in the plugin itself and remove any reference to internal implementation so that other could provide some custome implementation (for now I do not see any reasons but could be).
One example is the blue-ocean-plugin declared dead but who implemented the pipeline on top of bitbucket-source-branch plugin had use internal methods.